Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S/SS counts on the global leaderboard don't include silver S/SS #2081

Closed
MillhioreF opened this issue Dec 23, 2017 · 1 comment · Fixed by #2096
Closed

S/SS counts on the global leaderboard don't include silver S/SS #2081

MillhioreF opened this issue Dec 23, 2017 · 1 comment · Fixed by #2096

Comments

@MillhioreF
Copy link

The migration script seems to have taken this into account (Cookiezi's rank totals are correctly combined) but users that set scores after the migration regressed into not including silver ranks.

@MillhioreF MillhioreF changed the title SS/S counts on the global leaderboard don't include silver S/SS S/SS counts on the global leaderboard don't include silver S/SS Dec 23, 2017
@peppy
Copy link
Sponsor Member

peppy commented Dec 23, 2017

The reprocess is actually still running currently, so it's quite possible some users haven't been reached. What you are seeing above is correct numbers post-maintenance. The issue is that the ranking page is not adding the hidden numbers correctly (see

{{ number_format(max(0, $score->x_rank_count)) }}
)

Should be an easy fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants