New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show favourite beatmaps on user profile in reverse favourited order #1999

Merged
merged 1 commit into from Dec 18, 2017

Conversation

2 participants
@notbakaneko
Contributor

notbakaneko commented Dec 15, 2017

sort of related to #1944

tried adding an index to dateadded for sorting but mysql didn't seem to want to use it

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 17, 2017

Member

What's the reason for dropping back to raw sql?

Member

peppy commented Dec 17, 2017

What's the reason for dropping back to raw sql?

@notbakaneko

This comment has been minimized.

Show comment
Hide comment
@notbakaneko

notbakaneko Dec 18, 2017

Contributor

hasManyThrough doesn't work on composite keys and the ordering needs to be done on the intermediary table; we can't just select ids and select Beatmapset since that won't return the correct order.

Contributor

notbakaneko commented Dec 18, 2017

hasManyThrough doesn't work on composite keys and the ordering needs to be done on the intermediary table; we can't just select ids and select Beatmapset since that won't return the correct order.

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 18, 2017

Member

lame

Member

peppy commented Dec 18, 2017

lame

@peppy peppy merged commit 1fc7e8e into ppy:master Dec 18, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@notbakaneko

This comment has been minimized.

Show comment
Hide comment
@notbakaneko

notbakaneko Dec 18, 2017

Contributor

apparently this is breaking search :|

Contributor

notbakaneko commented Dec 18, 2017

apparently this is breaking search :|

@notbakaneko notbakaneko deleted the notbakaneko:feature/reverse-order-favourite-beatmaps branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment