New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow beatmap discussion reply editor to be closed #2020

Merged
merged 3 commits into from Dec 18, 2017

Conversation

3 participants
@notbakaneko
Contributor

notbakaneko commented Dec 18, 2017

with cancel button or esc key

@peppy peppy merged commit 1ce17d0 into ppy:master Dec 18, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/beatmap-discussion-cancel-reply branch Dec 18, 2017

@@ -74,6 +76,8 @@ class BeatmapDiscussions.NewReply extends React.PureComponent
className: "#{bn}__footer"
div className: "#{bn}__actions",
div className: "#{bn}__actions-group",
@renderCancelButton()

This comment has been minimized.

@nanaya

nanaya Dec 18, 2017

Collaborator

dis coo.

(probably should be removed)

@nanaya

nanaya Dec 18, 2017

Collaborator

dis coo.

(probably should be removed)

This comment has been minimized.

@notbakaneko

notbakaneko Dec 18, 2017

Contributor

😑

@notbakaneko

notbakaneko Dec 18, 2017

Contributor

😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment