Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable vote button initially; return more user-friendly error #2301

merged 3 commits into from Jan 31, 2018


2 participants
Copy link

commented Jan 31, 2018

fixes #2288

In theory, the error message shouldn't appear anymore.
Of course, this means you can't click the button anymore if js isn't enabled, but then again, there's going to be problems with the rest of the site without js enabled :trollface:


nanaya approved these changes Jan 31, 2018

@nanaya nanaya merged commit 7932ae5 into ppy:master Jan 31, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
continuous-integration/travis-ci/pr The Travis CI build passed

@notbakaneko notbakaneko deleted the notbakaneko:fix/2288 branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.