Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace missed instances of "log" with "sign" #2605

Merged
merged 9 commits into from Mar 30, 2018

Conversation

@Joehuu
Copy link
Member

@Joehuu Joehuu commented Mar 2, 2018

Don't know how to link tournaments to sign in, so I edited without it. I might miss other instances.

@peppy
Copy link
Member

@peppy peppy commented Mar 5, 2018

Probably want to add invalidation comments on other localisations

@TPGPL
Copy link
Contributor

@TPGPL TPGPL commented Mar 5, 2018

Polish is good

@kj415j45
Copy link
Contributor

@kj415j45 kj415j45 commented Mar 6, 2018

Request Change: Remove notes in zh locale files since nothing changed.

@kj415j45
Copy link
Contributor

@kj415j45 kj415j45 commented Mar 6, 2018

Besides, there's a change in en/Tournaments.php: :login -> sign in. I don't think this is correct.

(I don't create Line comment because my Chrome on mobile crash when loading so much changes :v)

@@ -33,7 +33,7 @@
'cancel' => 'Cancel Registration',
],
'entered' => 'Your are registered for this tournament.<br><br>Note that this does not mean you have been assigned to a team.<br><br>Further instructions will be sent to you via email closer to the tournament date, so please ensure your osu! account\'s email address is valid!',
'login_to_register' => 'Please :login to view registration details!',
'login_to_register' => 'Please sign in to view registration details!',

This comment has been minimized.

@nanaya

nanaya Mar 29, 2018
Collaborator

no need to change this one. The text uses whatever users.anonymous.login_link is.

Don't forget to remove comment for other locales.

@nanaya
nanaya approved these changes Mar 30, 2018
@nanaya nanaya merged commit 26b64d9 into ppy:master Mar 30, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Joehuu Joehuu deleted the Joehuu:replace-log-with-sign branch Apr 11, 2018
@Joehuu Joehuu restored the Joehuu:replace-log-with-sign branch Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants