Replace missed instances of "log" with "sign" #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably want to add invalidation comments on other localisations |
|
Polish is good |
|
⚠ Request Change: Remove notes in zh locale files since nothing changed. |
|
Besides, there's a change in (I don't create Line comment because my Chrome on mobile crash when loading so much changes :v) |
nanaya
requested changes
Mar 29, 2018
resources/lang/en/tournament.php
Outdated
| @@ -33,7 +33,7 @@ | |||
| 'cancel' => 'Cancel Registration', | |||
| ], | |||
| 'entered' => 'Your are registered for this tournament.<br><br>Note that this does not mean you have been assigned to a team.<br><br>Further instructions will be sent to you via email closer to the tournament date, so please ensure your osu! account\'s email address is valid!', | |||
| 'login_to_register' => 'Please :login to view registration details!', | |||
| 'login_to_register' => 'Please sign in to view registration details!', | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
nanaya
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know how to link tournaments to sign in, so I edited without it. I might miss other instances.