New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown and locale updates #2631

merged 5 commits into from Mar 6, 2018


2 participants

nanaya commented Mar 6, 2018

Fixes #2602, fixes #2600.


Now the news headers are broken :trollface:

@@ -92,11 +93,17 @@ public static function process($rawInput, $config)
public static function parseYamlHeader($input)
$hasMatch = preg_match('#^(?:---\n(?<header>.+?)\n(?:---|\.\.\.)\n)(?<document>.+)$#s', $input, $matches);
$hasMatch = preg_match('#^(?:---\n(?<header>.+?)\n(?:---|\.\.\.)\n)(?<document>.+)$#', $input, $matches);

This comment has been minimized.


notbakaneko Mar 6, 2018


This seems to fail to parse the news headers since there's usually more than one new line after the ending ---

This comment has been minimized.


nanaya Mar 6, 2018


got confused between /g and /s 💃

@nanaya nanaya force-pushed the nanaya:markdown_update branch from 7a50b8b to aee2760 Mar 6, 2018

@notbakaneko notbakaneko merged commit 30e294f into ppy:master Mar 6, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
continuous-integration/travis-ci/pr The Travis CI build passed

@nanaya nanaya deleted the nanaya:markdown_update branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment