New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API beatmapset lookup endpoint #2639

Merged
merged 2 commits into from Mar 7, 2018

Conversation

2 participants
@nekodex
Collaborator

nekodex commented Mar 7, 2018

Similar to beatmap lookup, currently only supports looking up by beatmap_id.

e.g.: /api/v2/beatmapsets/lookup?beatmap_id=660345

Ideally this functionality will eventually be merged into search, along with the ability to search other beatmap/set metadata, etc.

fixes #2625

nekodex added some commits Mar 7, 2018

});
Route::resource('rooms', 'RoomsController', ['only' => ['show']]);
Route::group(['prefix' => 'beatmapsets'], function () {
Route::get('favourites', ['uses' => 'BeatmapsetsController@favourites']); // GET /api/v2/beatmapsets/favourites
Route::get('favourites', 'BeatmapsetsController@favourites'); // GET /api/v2/beatmapsets/favourites

This comment has been minimized.

@nanaya

nanaya Mar 7, 2018

Collaborator

might as well merge with the // Beatmapsets group below while at it?

This comment has been minimized.

@nekodex

nekodex Mar 7, 2018

Collaborator

hrm I wonder if that endpoint should be nested under users or me instead?

This comment has been minimized.

@nanaya

nanaya Mar 7, 2018

Collaborator

hrm right 😕

This comment has been minimized.

@nekodex

nekodex Mar 7, 2018

Collaborator

Actually that endpoint probably isn't even needed anymore (duplicate functionality in /api/v2/users/:user_id/beatmapsets/favourite), I'll make a new PR removing that stuff.

@nanaya

nanaya approved these changes Mar 7, 2018

@nanaya nanaya merged commit 5904296 into ppy:master Mar 7, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nekodex nekodex deleted the nekodex:api/beatmapset-lookup branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment