New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix success rate display for beatmaps #2658

Merged
merged 3 commits into from Mar 9, 2018

Conversation

2 participants
@nekodex
Collaborator

nekodex commented Mar 9, 2018

Previous calculation was dividing passcount by playcount + passcount for some reason.

Also adds a tooltip to the percentage to also show raw pass/play counts.

fixes #2652

nekodex added some commits Mar 9, 2018

@nanaya

nanaya approved these changes Mar 9, 2018

@nanaya nanaya merged commit 160da1f into ppy:master Mar 9, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nekodex nekodex deleted the nekodex:fix-success-rate branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment