New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client beatmap discussion failing to parse url with empty path components #2690

Merged
merged 5 commits into from Mar 14, 2018

Conversation

2 participants
@notbakaneko
Contributor

notbakaneko commented Mar 14, 2018

Fixes parse failing when url has a trailing / or one of the components is empty.
Also does whitelisting of mode and filter when parsing.

@notbakaneko notbakaneko force-pushed the notbakaneko:fix/beatmap-discussion-path-parsing branch from a3e9089 to 32dff59 Mar 14, 2018

@notbakaneko notbakaneko changed the title from Fix client beatmap discussion parsing failing to Fix client beatmap discussion failing to parse url with empty path components Mar 14, 2018

@@ -21,6 +21,9 @@ class @BeatmapDiscussionHelper
@DEFAULT_MODE: 'timeline'
@DEFAULT_FILTER: 'total'
@MODES = ['timeline', 'general', 'generalAll']

This comment has been minimized.

@nanaya

nanaya Mar 14, 2018

Collaborator

events?

notbakaneko and others added some commits Mar 14, 2018

@nanaya

nanaya approved these changes Mar 14, 2018

@nanaya nanaya merged commit 48ce167 into ppy:master Mar 14, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:fix/beatmap-discussion-path-parsing branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment