New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbolinks, react, and navigation #2710

merged 6 commits into from Mar 22, 2018


3 participants

nanaya commented Mar 16, 2018

Should fix part of #2696. Need more checks. There are some components not yet updated to registerPersistent thingy.

  • unmount after replacing the page
  • save state on before-cache to where the component is attached to
  • disable anchor existence check in turbolinks because some of the anchors used don't exist which causes page fetch on history navigation

nanaya added some commits Mar 15, 2018

Create matching id
Turbolinks doesn't like it when the page doesn't contain the anchored element.
mode: optionsHash.playmode
@state = JSON.parse(@props.container.dataset.state ? 'null')
@restoredState = @state?
console.log 'restored state?', @restoredState

This comment has been minimized.


nekodex Mar 21, 2018




This comment has been minimized.


nekodex commented Mar 21, 2018

If you navigate back/forwards while scores are being loaded on the beatmap page, the page gets stuck in the 'loading' state.

@peppy peppy merged commit 8ed0064 into ppy:master Mar 22, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
continuous-integration/travis-ci/pr The Travis CI build passed

@nanaya nanaya deleted the nanaya:navigation branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment