New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to to user post history #2711

Merged
merged 52 commits into from Mar 23, 2018

Conversation

3 participants
@notbakaneko
Contributor

notbakaneko commented Mar 16, 2018

Adds a link to the user's post history on their profile page.
fixes #2059

also pulls in more changes for/from #2590

@endif
{{-- FIXME: remove querystring check? --}}
@if ($fields['topicId'] !== false && present(request($fields['topicId'])))

This comment has been minimized.

@nanaya

nanaya Mar 20, 2018

Collaborator

wtf is all this !== false check ಠ_ಠ

This comment has been minimized.

@nanaya

nanaya Mar 20, 2018

Collaborator

I see ಠ_ಠ but why not just null

This comment has been minimized.

@notbakaneko

notbakaneko Mar 21, 2018

Contributor

null or !isset meant to use the existing value, until I changed it to always force the defaults, so I guess it has no meaning now 💃

@@ -131,12 +131,15 @@ public function quickSearch()
public function search()
{
if (Request::input('mode') === 'beatmapset') {
$mode = request('mode');

This comment has been minimized.

@nanaya

nanaya Mar 23, 2018

Collaborator

stuff added, and removed, and this somehow left behind.

'posts' => [
'title' => ':username\'s posts',
'page_description' => 'osu! - Everything you ever wanted to know about :username!',

This comment has been minimized.

@nanaya

nanaya Mar 23, 2018

Collaborator

wat

notbakaneko added some commits Mar 23, 2018

@nanaya

nanaya approved these changes Mar 23, 2018

@nanaya nanaya merged commit 5771c55 into ppy:master Mar 23, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/user-profile-posts-search branch Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment