New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-family for non-latin character sets. #2735

Merged
merged 2 commits into from Mar 20, 2018

Conversation

3 participants
@notbakaneko
Contributor

notbakaneko commented Mar 19, 2018

includes #2684

Hiragino Kaku Gothic ProN - Japanese and Chinese text on OSX and iOS.
Apple SD Gothic Neo - Hangul on OSX
Meiryo - Japanese on Vista+
Microsoft YaHei - Chinese on Vista+
sans-serif should fallback to some form of Hiragino Sans or Hiragino Sans GB on OSX or SimHei/SimSun? on WIndows

Also removes the mythical Arial Grande

Update font-family for non-latin character sets.
Also, "Arial Grande" is not a thing :best:
@shortthu

This comment has been minimized.

Contributor

shortthu commented Mar 19, 2018

Can we have something for Vietnamese too? They are not fully supported in Exo 2
Found on Google Fonts that Exo (1) have Vietnamese support

@nanaya

nanaya approved these changes Mar 20, 2018

@nanaya

This comment has been minimized.

Collaborator

nanaya commented Mar 20, 2018

@shortthu I don't think we're adding more web fonts. Otherwise feel free suggesting better font(s) for your preferred languages.

@nanaya nanaya merged commit 78eded8 into ppy:master Mar 20, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/font-update branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment