Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User badge #2826

Merged
merged 14 commits into from Mar 30, 2018
Merged

User badge #2826

merged 14 commits into from Mar 30, 2018

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Mar 27, 2018

Show the badges. Upscaled and stuff.

@nekodex
Copy link
Collaborator

nekodex commented Mar 29, 2018

In IE11 the marquee animation doesn't play and the popup doesn't resize correctly:

Safari (desktop and mobile) doesn't seem to mask properly:

@peppy
Copy link
Sponsor Member

peppy commented Mar 29, 2018

  • On first appearance, the marquee effect should decelerate probably over two or three circulations of all badges (if more than one is present). Currently the effect is pretty hard to see.
  • May want to change alignment to left aligned when expanded, looks a bit weird with centered rows of unequal length.

@nekodex nekodex merged commit 627e18a into ppy:master Mar 30, 2018
@nanaya nanaya deleted the user_badge branch May 21, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants