Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User badge #2826

Merged
merged 14 commits into from Mar 30, 2018
Merged

User badge #2826

merged 14 commits into from Mar 30, 2018

Conversation

@nanaya
Copy link
Collaborator

@nanaya nanaya commented Mar 27, 2018

Show the badges. Upscaled and stuff.

@nanaya nanaya force-pushed the nanaya:user_badge branch from 5b0e6b5 to 4ce6c9c Mar 27, 2018
nanaya added 3 commits Mar 26, 2018
Hopefully not needed anymore.
@nanaya nanaya force-pushed the nanaya:user_badge branch from 4ce6c9c to b6b64c1 Mar 27, 2018
@nekodex
Copy link
Collaborator

@nekodex nekodex commented Mar 29, 2018

In IE11 the marquee animation doesn't play and the popup doesn't resize correctly:

Safari (desktop and mobile) doesn't seem to mask properly:

@peppy
Copy link
Member

@peppy peppy commented Mar 29, 2018

  • On first appearance, the marquee effect should decelerate probably over two or three circulations of all badges (if more than one is present). Currently the effect is pretty hard to see.
  • May want to change alignment to left aligned when expanded, looks a bit weird with centered rows of unequal length.
@peppy peppy added this to the March 2018 milestone Mar 29, 2018
nanaya and others added 9 commits Mar 29, 2018
@nekodex nekodex merged commit 627e18a into ppy:master Mar 30, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nanaya nanaya deleted the nanaya:user_badge branch May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.