Elasticsearch settings update #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
notbakaneko
commented
Mar 27, 2018
notbakaneko
commented
- configurable number of shards when creating index (doesn't affect existing indices)
- increment error counter on Datadog on exception
notbakaneko
force-pushed
the
feature/es-settings-update-201803
branch
from
9d94c68
to
7d55abe
Compare
nanaya
requested changes
Mar 27, 2018
app/helpers.php
Outdated
| @@ -141,7 +141,13 @@ function es_search($params) | |||
| $error = $e; | |||
| } | |||
|
|
|||
| Log::debug($error); | |||
| if (isset($error) && config('datadog-helper.enabled')) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -152,6 +153,14 @@ private function fetch() | |||
| $this->error = $e; | |||
| } | |||
|
|
|||
| if (isset($this->error) && config('datadog-helper.enabled')) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
nanaya
previously approved these changes
Mar 28, 2018
nanaya
force-pushed
the
feature/es-settings-update-201803
branch
from
4434d16
to
3db4d9e
Compare
nanaya
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.