New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch settings update #2827

Merged
merged 4 commits into from Mar 28, 2018

Conversation

2 participants
@notbakaneko
Contributor

notbakaneko commented Mar 27, 2018

  • configurable number of shards when creating index (doesn't affect existing indices)
  • increment error counter on Datadog on exception

@notbakaneko notbakaneko added the search label Mar 27, 2018

@@ -141,7 +141,13 @@ function es_search($params)
$error = $e;
}
Log::debug($error);
if (isset($error) && config('datadog-helper.enabled')) {

This comment has been minimized.

@nanaya

nanaya Mar 27, 2018

Collaborator

isset check rather useless because it's always assigned with exception? And not sure why there's a null coalesce at the end =D

This comment has been minimized.

@notbakaneko

notbakaneko Mar 27, 2018

Contributor

oh wait, forgot about the return up there :best:

@@ -152,6 +153,14 @@ private function fetch()
$this->error = $e;
}
if (isset($this->error) && config('datadog-helper.enabled')) {

This comment has been minimized.

@nanaya

nanaya Mar 27, 2018

Collaborator

See other comment about isset check.

@nanaya nanaya dismissed their stale review via 3db4d9e Mar 28, 2018

@nanaya

nanaya approved these changes Mar 28, 2018

@nanaya nanaya merged commit 26d530f into ppy:master Mar 28, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/es-settings-update-201803 branch Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment