models are not going to be coupled directly to indices; we can have a different index where it's valid to call ->records() to get Beatmapsets from indices that are not beatmap. RecordSearch is supposed to support any arbitrary combination.
HasSearch is usable as a base for ES joining queries, params contains stuff that shouldn't be included. Params is for inputs from some source to be parsed and allowed to be handled separately before a Search subclass is called; they aren't going to be combined
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.