Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] completed japanese localisation for some files #2891

Merged
merged 13 commits into from Apr 19, 2018

Conversation

@Soukyuen
Copy link
Contributor

@Soukyuen Soukyuen commented Apr 2, 2018

No description provided.

Soukyuen added 3 commits Apr 2, 2018
…sers, livestreams, home, admin, accounts.php
@peppy peppy added this to the Candidate Issues milestone Apr 2, 2018
@nanaya
Copy link
Collaborator

@nanaya nanaya commented Apr 3, 2018

For generic pluralized translations - the ones with :count but without specific numbers ({0}, [2,*], etc) - please only specify one.

So instead of

'1 曲|:count 曲'

Just

':count曲'

(space separator optional)

@kj415j45
Copy link
Contributor

@kj415j45 kj415j45 commented Apr 3, 2018

(zh and zh-tw add space between ':count' and '曲', since the font issue)

'players' => '累計登録者数<strong>:count</strong>人',

'slogan' => [
'main' => '基本無料で最高のリズムゲーム',

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

i think 基本料無料 sounds more natural


'pages' => [
'root' => [
'title' => 'アドミンのコンソールっぽいの',

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

アドミンのコンソールのようなもの sounds better

This comment has been minimized.

@nanaya

nanaya Apr 9, 2018
Collaborator

...lol what have I done. Shouldn't have put that thingy word in English version. Something like "管理コンソール" should be fine.

This comment has been minimized.

@Soukyuen

Soukyuen Apr 9, 2018
Author Contributor

it's cute but yea will do


'register' => '登録',
'reset' => 'リセット',
'new' => '新',

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

更新(renew some information) or 新規 (newly register somebody/something's information) sounds better; check context and apply the full term if possible.

This comment has been minimized.

@Soukyuen

Soukyuen Apr 9, 2018
Author Contributor

I actually tried to look for the context, but I couldn't figure out where this string appeared. It's basically a placeholder until I can find this :(

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

I can't readily check for context, but in that case 新しい probably works better than just 新

This comment has been minimized.

@notbakaneko

notbakaneko Apr 9, 2018
Collaborator

I think most of the user ones are actually unused

],
'store' => [
'_' => 'ストア',
'checkout-show' => '清算',

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

精算 (fare adjustment) is better than 清算 (clear/settle something like debt) in this case.

'getListing' => 'リスト',
'cart-show' => 'カート',

'getCheckout' => '清算',

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

精算 (fare adjustment) is better than 清算 (clear/settle something like debt) in this case.


return [
'defaults' => [
'page_description' => 'osu! - リズムはもう、その指作に! 某応援団や某太鼓のゲームをモチーフにしたゲームモードにオリジナルのゲームモードも楽しめ、譜面作成までも完全にサポートされているゲームです。',

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

指作に should be 指先に 

return [
'top-headers' => [
'headline' => 'ライブ配信',
'description' => '五分度にtwitch.tvからデータを受信してリストを表示しています。osu!をプレイ中に設定して配信を始めるとリストに表示される様になります。配信方法についてはwikiを参照してください。',

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

5分度 should be 5分後(in 5 minutes) or 5分毎 (every 5 minutes).
In this context, maybe 5分毎 (every 5 minutes) sounds better.

'404' => 'ユーザーが見つかりませんでした。',
'age' => ':age歳',
'change_avatar' => 'アバター画像の変更',
'first_members' => '創設時からメンバー',

This comment has been minimized.

@peppy

peppy Apr 9, 2018
Member

創設時からのメンバー (sounds better to put "の" after 創設時から)

@peppy
Copy link
Member

@peppy peppy commented Apr 18, 2018

@Soukyuen any chance you can apply the review changes so we can get this basic level of localisation live?

peppy and others added 3 commits Apr 18, 2018
@Soukyuen
Copy link
Contributor Author

@Soukyuen Soukyuen commented Apr 18, 2018

oh what the heck

Soukyuen added 4 commits Apr 18, 2018
Copy link
Contributor Author

@Soukyuen Soukyuen left a comment

all changes on translation are in this one bd06bea
i made a huge mistake and edited the wrong files so some quote fixes are reverted
all the following commits are my lazy attempts at trying to fix the syntax errors

@Soukyuen
Copy link
Contributor Author

@Soukyuen Soukyuen commented Apr 19, 2018

@peppy it's updated if you wanted me to let you know

@peppy
peppy approved these changes Apr 19, 2018
@peppy
Copy link
Member

@peppy peppy commented Apr 19, 2018

Let's get this up and running!

@peppy peppy merged commit c5c0b49 into ppy:master Apr 19, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.