Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check user is trying to checkout with current cart #2901



Copy link

@notbakaneko notbakaneko commented Apr 4, 2018

Check that the user is trying to checkout with the current cart instead of an old one when beginning checkout. This resolves an issue where a user tries to checkout in one tab but deletes and creates a new cart in a different tab.

A side-effect of this is; trying to do a free checkout with a non-free order will now force the page to reload instead of showing the loading overlay forever (still won't checkout).
That was a bug :D

@@ -37,13 +37,14 @@ export class StoreCheckout

$(@CHECKOUT_SELECTOR).on 'click.checkout', (event) =>
provider =
orderId =

This comment was marked as off-topic.

This comment was marked as off-topic.

@nanaya nanaya merged commit b0b15e2 into ppy:master Apr 4, 2018
@notbakaneko notbakaneko deleted the feature/store/check-stale-cart-checkout branch April 5, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants