Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck user is trying to checkout with current cart #2901
Conversation
notbakaneko
added some commits
Apr 4, 2018
notbakaneko
added
the
store
label
Apr 4, 2018
| @@ -37,13 +37,14 @@ export class StoreCheckout | ||
| $(@CHECKOUT_SELECTOR).on 'click.checkout', (event) => | ||
| provider = event.target.dataset.provider | ||
| orderId = event.target.dataset.orderId |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nanaya
merged commit b0b15e2
into
ppy:master
Apr 4, 2018
notbakaneko
deleted the
notbakaneko:feature/store/check-stale-cart-checkout
branch
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
notbakaneko commentedApr 4, 2018
•
edited
Check that the user is trying to checkout with the current cart instead of an old one when beginning checkout. This resolves an issue where a user tries to checkout in one tab but deletes and creates a new cart in a different tab.
A side-effect of this is; trying to do a free checkout with a non-free order will now force the page to reload instead of showing the loading overlay forever (still won't checkout).That was a bug :D