Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor post editor (and footer) #2902

Merged
merged 3 commits into from Apr 5, 2018

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Apr 4, 2018

  • migrate profile page editor to use BBCodeEditor
  • cleanup the component
  • migrate topic creation page to use shared footer component
  • fix toolbar alignment. Fixes Leave space between these buttons in polls #2887
  • (css) style updates
  • other related stuff

@notbakaneko notbakaneko self-requested a review April 4, 2018 11:23
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-editor-footer should probably be named after its function as a toolbar since the block only a footer by coincidence? (and already in a footer element)

@nanaya
Copy link
Collaborator Author

nanaya commented Apr 5, 2018

But there's already post-box-toolbar m(。_°)m

@notbakaneko notbakaneko merged commit cf7685d into ppy:master Apr 5, 2018
@nanaya nanaya deleted the forum_topic_create_fixes branch May 21, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leave space between these buttons in polls
3 participants