New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor post editor (and footer) #2902

Merged
merged 3 commits into from Apr 5, 2018

Conversation

3 participants
@nanaya
Collaborator

nanaya commented Apr 4, 2018

  • migrate profile page editor to use BBCodeEditor
  • cleanup the component
  • migrate topic creation page to use shared footer component
  • fix toolbar alignment. Fixes #2887
  • (css) style updates
  • other related stuff

nanaya added some commits Apr 4, 2018

Synchronize the fancy toggle its related form on load
Because some browsers restore previous state on reload.

@notbakaneko notbakaneko self-requested a review Apr 4, 2018

@notbakaneko

post-editor-footer should probably be named after its function as a toolbar since the block only a footer by coincidence? (and already in a footer element)

@nanaya

This comment has been minimized.

Collaborator

nanaya commented Apr 5, 2018

But there's already post-box-toolbar m(。_°)m

@notbakaneko notbakaneko merged commit cf7685d into ppy:master Apr 5, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nanaya nanaya deleted the nanaya:forum_topic_create_fixes branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment