Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new header design #2906

Merged
merged 29 commits into from
Apr 5, 2018
Merged

Implement the new header design #2906

merged 29 commits into from
Apr 5, 2018

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Apr 4, 2018

RIP stuff (mainly quick search and current page breadcrumbs).

I think there are still quite a few leftover from old stuff (translations, etc).

Probably will be cleaned up a bit more later ┐(°~° )┌

continue if popup.dataset.clickMenuId != @currentMenu

currentPopup = popup
link = document.querySelector(".js-click-menu[data-click-menu-target='#{@currentMenu}'")

This comment was marked as off-topic.

@@ -55,8 +56,7 @@ $(document).on 'turbolinks:load', ->
@globalDrag ?= new GlobalDrag
@landingGraph ?= new LandingGraph
@menu ?= new Menu
@nav ?= new Nav

This comment was marked as off-topic.

right: 100%;
width: 3px;
height: calc(100% ~'-' (@_link-padding-vertical * 2 + @_link-highlight-margin-vertical * 2));
background-color: @yellow;

This comment was marked as off-topic.

@@ -145,12 +145,13 @@ public function search()
]);

$search = new Search($params);
$isSearchPage = true;

This comment was marked as off-topic.

This comment was marked as off-topic.

@notbakaneko notbakaneko merged commit f81d3a8 into ppy:master Apr 5, 2018
@peppy peppy added this to the April 2018 milestone Apr 5, 2018
@peppy peppy changed the title New header Implement the new header design Apr 5, 2018
@nanaya nanaya deleted the new_header branch May 21, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants