New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use simple_query_string instead of query_string #2935

Merged
merged 1 commit into from Apr 7, 2018

Conversation

2 participants
@notbakaneko
Contributor

notbakaneko commented Apr 6, 2018

simple_query_string discards the invalid parts of query_string instead of letting Lucene explode on badly formed queries.

tbh, neither should be used for public facing queries

@notbakaneko notbakaneko added the search label Apr 6, 2018

@peppy peppy added this to the April 2018 milestone Apr 7, 2018

@peppy peppy merged commit 5c4a2ad into ppy:master Apr 7, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/search/use-simple_query_string branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment