Add missing tables and test for model table existence #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
force-pushed
the
feature/test-table-existence
branch
from
cc8b783
to
8c00798
Compare
otherwise laravel will try incompatible defaults :D
notbakaneko
changed the title
nanaya
requested changes
Apr 10, 2018
tests/TableTest.php
Outdated
| private function checkDir(string $basePath, string $namespace = '') | ||
| { | ||
| $errors = []; | ||
| $entries = scandir($basePath); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
tests/TableTest.php
Outdated
| $errors = $this->checkDir($this->modelsPath); | ||
|
|
||
| // prints a diff with the classes that errored. | ||
| $this->assertEquals([], $errors); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Might as well since it's already a dependency of other packages
nanaya
reviewed
Apr 12, 2018
tests/TableTest.php
Outdated
| { | ||
| $errors = []; | ||
|
|
||
| $files = (new Finder)->in(app_path().'/Models')->files(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
nanaya
reviewed
Apr 12, 2018
composer.json
Outdated
| @@ -37,6 +37,7 @@ | |||
| "paypal/rest-api-sdk-php": "*", | |||
| "predis/predis": "~1.0", | |||
| "sentry/sentry-laravel": "*", | |||
| "symfony/finder": "*", | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
nanaya
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.