Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd missing tables and test for model table existence #2953
Conversation
notbakaneko
added
the
WIP
label
Apr 10, 2018
notbakaneko
added some commits
Apr 10, 2018
notbakaneko
removed
the
WIP
label
Apr 10, 2018
notbakaneko
changed the title from
Add test for model table existence
to
Add missing tables and test for model table existence
Apr 10, 2018
tests/TableTest.php
Outdated
| private function checkDir(string $basePath, string $namespace = '') | ||
| { | ||
| $errors = []; | ||
| $entries = scandir($basePath); |
This comment has been minimized.
This comment has been minimized.
tests/TableTest.php
Outdated
| $errors = $this->checkDir($this->modelsPath); | ||
| // prints a diff with the classes that errored. | ||
| $this->assertEquals([], $errors); |
This comment has been minimized.
This comment has been minimized.
tests/TableTest.php
Outdated
| { | ||
| $errors = []; | ||
| $files = (new Finder)->in(app_path().'/Models')->files(); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
composer.json
Outdated
| @@ -37,6 +37,7 @@ | ||
| "paypal/rest-api-sdk-php": "*", | ||
| "predis/predis": "~1.0", | ||
| "sentry/sentry-laravel": "*", | ||
| "symfony/finder": "*", |
This comment has been minimized.
This comment has been minimized.
nanaya
Apr 12, 2018
Collaborator
this probably isn't needed. If laravel changes the return, it'll explode in different way anyway and this wouldn't help ┐(°～° )┌
nanaya
merged commit dc5782d
into
ppy:master
Apr 12, 2018
notbakaneko
deleted the
notbakaneko:feature/test-table-existence
branch
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
notbakaneko commentedApr 10, 2018
No description provided.