Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tables and test for model table existence #2953

Merged
merged 11 commits into from Apr 12, 2018

Conversation

notbakaneko
Copy link
Collaborator

No description provided.

@notbakaneko notbakaneko removed the WIP label Apr 10, 2018
@notbakaneko notbakaneko changed the title Add test for model table existence Add missing tables and test for model table existence Apr 10, 2018
private function checkDir(string $basePath, string $namespace = '')
{
$errors = [];
$entries = scandir($basePath);

This comment was marked as off-topic.

$errors = $this->checkDir($this->modelsPath);

// prints a diff with the classes that errored.
$this->assertEquals([], $errors);

This comment was marked as off-topic.

Might as well since it's already a dependency of other packages
{
$errors = [];

$files = (new Finder)->in(app_path().'/Models')->files();

This comment was marked as off-topic.

This comment was marked as off-topic.

composer.json Outdated
@@ -37,6 +37,7 @@
"paypal/rest-api-sdk-php": "*",
"predis/predis": "~1.0",
"sentry/sentry-laravel": "*",
"symfony/finder": "*",

This comment was marked as off-topic.

@nanaya nanaya merged commit dc5782d into ppy:master Apr 12, 2018
@notbakaneko notbakaneko deleted the feature/test-table-existence branch April 12, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants