New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send order confirmation mail after store payment received #2956

Merged
merged 9 commits into from Apr 12, 2018

Conversation

3 participants
@notbakaneko
Contributor

notbakaneko commented Apr 10, 2018

fixes #2895

return $this->text(i18n_view('emails.store.payment_completed'))
->with($this->params)
->from('osustore@ppy.sh', 'osu!store team')
->subject('We received your osu!store order!');

This comment has been minimized.

@nanaya

nanaya Apr 10, 2018

Collaborator

translation?

@endforeach
@if ($order->requiresShipping())
We have received your payment and are preparing your order for shipping. It may take a few days for us to send it out, depending on the quantity of orders. You can follow the progress of your order at {{ route('store.invoice.show', $order) }}, including tracking details where available.

This comment has been minimized.

@nanaya

nanaya Apr 10, 2018

Collaborator

Always put link to order page even for orders without shipping? (perhaps on its own line or something)

{{ $item->quantity }} x {{ $item->getDisplayName() }} ({{ currency($item->subtotal()) }})
@endforeach
@if ($order->requiresShipping())

This comment has been minimized.

@nanaya

nanaya Apr 10, 2018

Collaborator

add shipping cost and total?

@@ -119,6 +122,17 @@ public function scopeWherePaymentTransactionId($query, $transactionId, $provider
->where('cancelled', false));
}
public function dispatchMail()

This comment has been minimized.

@nanaya

nanaya Apr 10, 2018

Collaborator

Not sure if should be here. Doesn't help it only sends payment completed mail.

@peppy peppy added store resolves issue and removed store labels Apr 12, 2018

{{ $item->quantity }} x {{ $item->getDisplayName() }} ({{ currency($item->subtotal()) }})
@endforeach
@if ($order->shipping)

This comment has been minimized.

@nanaya

nanaya Apr 12, 2018

Collaborator

is it checking for > 0?

@nanaya

nanaya approved these changes Apr 12, 2018

nanaya added some commits Apr 12, 2018

@nanaya nanaya merged commit 196e2e6 into ppy:master Apr 12, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/store/confirmation-mail branch Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment