New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Laravel's `File` thingy #2957

Merged
merged 4 commits into from Apr 12, 2018

Conversation

3 participants
@nanaya
Collaborator

nanaya commented Apr 10, 2018

TIL ┐(' ヮ' )┌

if (is_file($entryPath) && ends_with($entryPath, '.php')) {
$files[] = $entryPath;
}
foreach (File::allFiles($this->basePath($locale)) as $entry) {

This comment has been minimized.

@notbakaneko

notbakaneko Apr 12, 2018

Contributor

can just return File::allFiles directly and ->getPathname() in heads() or some of those other SplFileInfo methods

@peppy peppy added the code quality label Apr 12, 2018

@peppy peppy added this to the April 2018 milestone Apr 12, 2018

notbakaneko added some commits Apr 12, 2018

@notbakaneko notbakaneko merged commit 0130b29 into ppy:master Apr 12, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nanaya nanaya deleted the nanaya:simpler_locale_check_files branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment