Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait to acquire row lock before checking if record can be deleted. #2965


Copy link

It should be waiting for status to finish committing, otherwise it's doing the check with an old value and then queueing the delete anyway

@notbakaneko notbakaneko force-pushed the feature/store/lock-row-before-checking-modifiable branch from 5ba53f5 to f074785 Compare April 11, 2018 10:56
// would return a new cart anyway?
throw new Exception("Delete not allowed on Order ({$this->getKey()}).");
DB::connection($this->connection)->transaction(function () {

This comment was marked as off-topic.

This comment was marked as off-topic.

@nanaya nanaya merged commit 09a84f8 into ppy:master Apr 12, 2018
@notbakaneko notbakaneko deleted the feature/store/lock-row-before-checking-modifiable branch April 12, 2018 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants