Wait to acquire row lock before checking if record can be deleted. #2965
Conversation
notbakaneko
force-pushed the
notbakaneko:feature/store/lock-row-before-checking-modifiable
branch
from
5ba53f5
to
f074785
app/Models/Store/Order.php
Outdated
| // would return a new cart anyway? | ||
| throw new Exception("Delete not allowed on Order ({$this->getKey()})."); | ||
| } | ||
| DB::connection($this->connection)->transaction(function () { |
nanaya
Apr 11, 2018
Collaborator
$this->getConnection()->transaction(...) looks like the same thing.
$this->getConnection()->transaction(...) looks like the same thing.
notbakaneko
Apr 11, 2018
Author
Collaborator
making a separate PR for the existing ones
making a separate PR for the existing ones
notbakaneko
deleted the
notbakaneko:feature/store/lock-row-before-checking-modifiable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It should be waiting for
statusto finish committing, otherwise it's doing the check with an old value and then queueing the delete anyway