Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWait to acquire row lock before checking if record can be deleted. #2965
Conversation
notbakaneko
added
bug
store
labels
Apr 11, 2018
app/Models/Store/Order.php
Outdated
| // would return a new cart anyway? | ||
| throw new Exception("Delete not allowed on Order ({$this->getKey()})."); | ||
| } | ||
| DB::connection($this->connection)->transaction(function () { |
This comment has been minimized.
This comment has been minimized.
nanaya
Apr 11, 2018
Collaborator
$this->getConnection()->transaction(...) looks like the same thing.
This comment has been minimized.
This comment has been minimized.
nanaya
merged commit 09a84f8
into
ppy:master
Apr 12, 2018
notbakaneko
deleted the
notbakaneko:feature/store/lock-row-before-checking-modifiable
branch
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
notbakaneko commentedApr 11, 2018
It should be waiting for
statusto finish committing, otherwise it's doing the check with an old value and then queueing the delete anyway