Wait to acquire row lock before checking if record can be deleted. #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
force-pushed
the
feature/store/lock-row-before-checking-modifiable
branch
from
5ba53f5
to
f074785
Compare
nanaya
requested changes
Apr 11, 2018
app/Models/Store/Order.php
Outdated
| // would return a new cart anyway? | ||
| throw new Exception("Delete not allowed on Order ({$this->getKey()})."); | ||
| } | ||
| DB::connection($this->connection)->transaction(function () { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
nanaya
approved these changes
Apr 12, 2018
notbakaneko
deleted the
feature/store/lock-row-before-checking-modifiable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be waiting for
statusto finish committing, otherwise it's doing the check with an old value and then queueing the delete anyway