Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danish translation all pages #2971

Merged
merged 20 commits into from Apr 20, 2018

Conversation

3 participants
@tailsdk
Copy link
Contributor

tailsdk commented Apr 11, 2018

Big update to translation adding rewriting some and fixing a lot

hi

@tailsdk tailsdk changed the title . Translation part 3 Apr 11, 2018

tailsdk added some commits Apr 11, 2018

@tailsdk tailsdk changed the title Translation part 3 [WIP] Danish translation (will finish the rest of the pages soon) Apr 12, 2018

@peppy peppy added the localisation label Apr 12, 2018

@peppy peppy added this to the Candidate Issues milestone Apr 12, 2018

tailsdk added some commits Apr 12, 2018

@tailsdk

This comment has been minimized.

Copy link
Contributor Author

tailsdk commented Apr 12, 2018

Fixed all translations

@tailsdk tailsdk changed the title [WIP] Danish translation (will finish the rest of the pages soon) Danish translation all pages Apr 12, 2018

@notbakaneko

This comment has been minimized.

Copy link
Contributor

notbakaneko commented Apr 13, 2018

Can you resolve the conflicts, it will probably be this line: https://github.com/ppy/osu-web/pull/2971/files#diff-def9e8864518363ab248c5ba26f8ec84R45

Update artist.php
resolving conflict
@tailsdk

This comment has been minimized.

Copy link
Contributor Author

tailsdk commented Apr 13, 2018

resolved the conflict

@notbakaneko
Copy link
Contributor

notbakaneko left a comment

These keys should be updated (either moved or replaced):

- beatmaps.nominations.reset_at
- beatmapsets.show.scoreboard.miss_count
- forum.topics.watch.to_not_watching_done
- forum.topics.watch.to_watching_done
- model_validation.beatmap_discussion.hype.guest
- model_validation.beatmap_discussion.hype.hyped
- model_validation.beatmap_discussion.hype.limit_exceeded
- model_validation.beatmap_discussion.hype.not_hypeable
- model_validation.beatmap_discussion.hype.owner
'qualified_soon' => 'Forventet at blive ranked snart, hvis ingen problemer bliver fundet.',
'required_text' => 'Nomineringer: :current/:required',
'reset_at' => 'Nomineringer er blevet nullstillet :time_ago af et nyt problem :discussion.',

This comment has been minimized.

@notbakaneko

notbakaneko Apr 16, 2018

Contributor

this should an array with nomination_reset and disqualify now

'qualified_soon' => 'Forventet at blive ranked snart, hvis ingen problemer bliver fundet.',
'required_text' => 'Nomineringer: :current/:required',
'reset_at' => 'Nomineringer er blevet nullstillet :time_ago af et nyt problem :discussion.',
'reset_confirm' => 'Er du sikker? Ved at slå et problem op, nulstiller du nomineringer.',

tailsdk added some commits Apr 18, 2018

Update beatmaps.php
updating beatmaps
@tailsdk

This comment has been minimized.

Copy link
Contributor Author

tailsdk commented Apr 19, 2018

shpuld be fixed now

tailsdk and others added some commits Apr 19, 2018

@notbakaneko
Copy link
Contributor

notbakaneko left a comment

there are some keys that were renamed, but we'll handle them separately

@notbakaneko notbakaneko merged commit 746bc8e into ppy:master Apr 20, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.