New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messages and featured artists song count pluralization i18n #2994

Merged
merged 4 commits into from Apr 13, 2018

Conversation

3 participants
@notbakaneko
Contributor

notbakaneko commented Apr 13, 2018

fixes #2991
fixes #2992

notbakaneko added some commits Apr 13, 2018

replace 1 with :count placeholder.
also fix a placeholder that was translated.

@notbakaneko notbakaneko changed the title from Fix featured artists song count pluralization i18n to Fix messages and featured artists song count pluralization i18n Apr 13, 2018

@nekodex nekodex merged commit 96c57d3 into ppy:master Apr 13, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nekodex

This comment has been minimized.

Collaborator

nekodex commented Apr 13, 2018

(as a note, corrected Russian translations were provided by Kyubey)

@notbakaneko notbakaneko deleted the notbakaneko:fix/feature-artist-song-count-i18n branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment