Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-awesome icon fixes #2996

Merged
merged 3 commits into from Apr 13, 2018
Merged

font-awesome icon fixes #2996

merged 3 commits into from Apr 13, 2018

Conversation

@nekodex
Copy link
Collaborator

@nekodex nekodex commented Apr 13, 2018

Fixes missing icons in beatmap discussion and replaces cloud download icon.

cloud

fixes #2993

nekodex added 2 commits Apr 13, 2018
@@ -236,7 +236,7 @@ public function supportTheGame()
'perks' => [
// localization's name => icon
'osu_direct' => 'fas fa-search',
'auto_downloads' => 'fas fa-cloud-download-alt',
'auto_downloads' => 'fas fa-download',
'upload_more' => 'fas fa-cloud-upload-alt',

This comment has been minimized.

@Joehuu

Joehuu Apr 13, 2018
Member

regular upload icon too

This comment has been minimized.

@nekodex

nekodex Apr 13, 2018
Author Collaborator

That page is being replaced "soon" anyway.

@peppy peppy added this to the April 2018 milestone Apr 13, 2018
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

cloud removed, bug fixed

@notbakaneko notbakaneko merged commit 3e21e5f into ppy:master Apr 13, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nekodex nekodex deleted the nekodex:fa-missing-icons branch Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.