Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define React and friends as externals in webpack #2998

Merged
merged 2 commits into from Apr 16, 2018

Conversation

3 participants
@notbakaneko
Copy link
Contributor

notbakaneko commented Apr 13, 2018

2 copies of React and friends were being served ( ゚ ヮ゚)

@peppy peppy added this to the April 2018 milestone Apr 13, 2018

@nanaya

This comment has been minimized.

Copy link
Collaborator

nanaya commented Apr 13, 2018

Is it from importing TextareaAutosize? Just noticed, shouldn't some of the import-shims be part of vendor? ಠ_ಠ

@notbakaneko

This comment has been minimized.

Copy link
Contributor Author

notbakaneko commented Apr 16, 2018

vendoronly contains pre-built modules that can be concat'ed together.

@nanaya

nanaya approved these changes Apr 16, 2018

@nanaya nanaya merged commit a027ce2 into ppy:master Apr 16, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/webpack-define-externals branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.