Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total first place rank count on profile; display pp instead of score #3022

Merged
merged 4 commits into from Apr 18, 2018

Conversation

3 participants
@nanaya
Copy link
Collaborator

nanaya commented Apr 16, 2018

Fixes #2941.

@nanaya

This comment has been minimized.

Copy link
Collaborator Author

nanaya commented Apr 16, 2018

I tried changing the score to show pp but then it means loved maps will be showing 0pp... ಠ_ಠ

@TPGPL

This comment has been minimized.

Copy link
Contributor

TPGPL commented Apr 16, 2018

maybe show pp only when the map is ranked then? 🤔

@nanaya nanaya changed the title User first place ranks count User first place ranks count and pp Apr 17, 2018

@peppy peppy changed the title User first place ranks count and pp Show total first place rank count on profile; display pp instead of score Apr 17, 2018

@peppy peppy merged commit 8852ebe into ppy:master Apr 18, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nanaya nanaya deleted the nanaya:user_first branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.