Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on new player for posting on forum #3036

Merged
merged 13 commits into from Apr 26, 2018

Conversation

@nanaya
Copy link
Collaborator

@nanaya nanaya commented Apr 18, 2018

No link because there's currently no way to embed link to error message. It doesn't sound like a good idea anyway for main message; perhaps add some kind of extended info to exceptions (and then a way to pass it from authorization).

Can use better wording for posting too many on help forums.

@nanaya nanaya force-pushed the nanaya:forum_post_permission branch from 85b8377 to 589177e Apr 18, 2018

'store' => [
'play_more' => 'Try playing the game before posting on the forums, please! If you have a problem with playing, please post to the Help and Support forum.',
'too_many_posts' => 'Please wait for responses of current posts.',

This comment has been minimized.

@peppy

peppy Apr 20, 2018
Member

incorrect key, and not sure this makes sense (as getting responses to posts doesn't increase your post limit)

@peppy peppy added this to the April 2018 milestone Apr 20, 2018
@peppy peppy added the area:forum label Apr 20, 2018
@peppy
Copy link
Member

@peppy peppy commented Apr 20, 2018

Oh, that's an actual test failing

@nanaya nanaya force-pushed the nanaya:forum_post_permission branch from 3b9e24e to c618a5c Apr 20, 2018

'store' => [
'play_more' => 'Try playing the game before posting on the forums, please! If you have a problem with playing, please post to the Help and Support forum.',
'too_many_help_posts' => 'Try playing the game before posting further. If you still have trouble playing, check help pages.',

This comment has been minimized.

@nekodex

nekodex Apr 26, 2018
Collaborator

Maybe something along the lines of "You need to play the game more before you can make additional posts. If you're still having trouble playing the game, email support@ppy.sh"?

@nekodex nekodex merged commit 6e502ae into ppy:master Apr 26, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nanaya nanaya deleted the nanaya:forum_post_permission branch May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants