Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd check on new player for posting on forum #3036
Conversation
resources/lang/en/authorization.php
Outdated
| 'store' => [ | ||
| 'play_more' => 'Try playing the game before posting on the forums, please! If you have a problem with playing, please post to the Help and Support forum.', | ||
| 'too_many_posts' => 'Please wait for responses of current posts.', |
This comment has been minimized.
This comment has been minimized.
peppy
Apr 20, 2018
Member
incorrect key, and not sure this makes sense (as getting responses to posts doesn't increase your post limit)
peppy
added this to the April 2018 milestone
Apr 20, 2018
peppy
added
the
forum
label
Apr 20, 2018
This comment has been minimized.
This comment has been minimized.
|
Oh, that's an actual test failing |
nanaya
added some commits
Apr 18, 2018
resources/lang/en/authorization.php
Outdated
| 'store' => [ | ||
| 'play_more' => 'Try playing the game before posting on the forums, please! If you have a problem with playing, please post to the Help and Support forum.', | ||
| 'too_many_help_posts' => 'Try playing the game before posting further. If you still have trouble playing, check help pages.', |
This comment has been minimized.
This comment has been minimized.
nekodex
Apr 26, 2018
•
Collaborator
Maybe something along the lines of "You need to play the game more before you can make additional posts. If you're still having trouble playing the game, email support@ppy.sh"?
nanaya
added some commits
Apr 26, 2018
nekodex
merged commit 6e502ae
into
ppy:master
Apr 26, 2018
nanaya
deleted the
nanaya:forum_post_permission
branch
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nanaya commentedApr 18, 2018
No link because there's currently no way to embed link to error message. It doesn't sound like a good idea anyway for main message; perhaps add some kind of extended info to exceptions (and then a way to pass it from authorization).
Can use better wording for posting too many on help forums.