Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beatmapset ranking queue system #3053

merged 2 commits into from Apr 23, 2018


Copy link

@nanaya nanaya commented Apr 20, 2018

Something like this...? Seems working.

@nanaya nanaya force-pushed the nanaya:beatmapset_queue_update branch from 3855709 to 33d85e1 Apr 20, 2018
$this->previous_queue_duration = ($this->queued_at ?? $this->approved_date)->diffinSeconds();
$this->queued_at = null;
} elseif ($this->isPending() && $state === 'qualified') {
$this->queued_at = $currentTime->copy()->subSeconds($this->previous_queue_duration);

This comment has been minimized.


peppy Apr 22, 2018

we'll want to ensure we always requeue at most static::MINIMUM_DAYS_FOR_RANKING - 1 days in the past, to enforce the 24 hours re-qualify limit.

This comment has been minimized.


nanaya Apr 22, 2018
Author Collaborator

can be done by filtering by approved_date, I believe.

@peppy peppy added this to the April 2018 milestone Apr 23, 2018
@peppy peppy merged commit 57f5e79 into ppy:master Apr 23, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
continuous-integration/travis-ci/pr The Travis CI build passed
@nanaya nanaya deleted the nanaya:beatmapset_queue_update branch May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants