New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed localisation for japanese #3071

Merged
merged 8 commits into from Apr 27, 2018

Conversation

3 participants
@Soukyuen
Contributor

Soukyuen commented Apr 23, 2018

all files are complete.
there are small modifications in existing files (looked at context and realized they didn't really fit).

Soukyuen added some commits Apr 23, 2018

return [
'event' => [
'approve' => '承認済みです。',
'discussion_delete' => 'モデレーターがディスカッション :discussion を削除しました。.',

This comment has been minimized.

@peppy

peppy Apr 23, 2018

Member

remove the spaces around variables in places like this.

@peppy

This comment has been minimized.

Member

peppy commented Apr 23, 2018

Just as a sanity check: are you testing this in a local environment?

@peppy peppy added the localisation label Apr 23, 2018

@peppy peppy added this to the April 2018 milestone Apr 23, 2018

@Soukyuen

This comment has been minimized.

Contributor

Soukyuen commented Apr 23, 2018

no, and I'm not sure how, actually.

Soukyuen added some commits Apr 23, 2018

@nanaya

This comment has been minimized.

Collaborator

nanaya commented Apr 25, 2018

Not part of this pull request but in wiki.php:

'fallback_translation' => 'ご希望のページはまだ現在選択している言語に翻訳されていません。 (:language). 英語版を表示します。',

should be

'fallback_translation' => 'ご希望のページはまだ現在選択している言語(:language)に翻訳されていません。英語版を表示します。',

though I feel that まだ should be put before 翻訳されていません. But then again my Japanese isn't all that good ┐(ツ)┌

ご希望のページは現在選択している言語(:language)にまだ翻訳されていません。

@Soukyuen

This comment has been minimized.

Contributor

Soukyuen commented Apr 25, 2018

I believe the order is good as is, but I will adjust the location of (:language)

'nearby_posts' => [
'confirm' => '自分の懸念点はまだ挙げられていません',
'notice' => ':timestamp (:existing_timestamps)付近に他の投稿があります。投稿する前に確認してください。',

This comment has been minimized.

@nanaya

nanaya Apr 26, 2018

Collaborator

(:existing_timestamps) should probably be either after 他の投稿 or があります (or some other location).

00:04.000付近に他の投稿があります(00:05.120、 00:04.837、 00:04.837、 00:06.392、と00:04.413)。

'discussion_post_delete' => 'モデレーターがディスカッション:discussionから投稿を削除しました。',
'discussion_post_restore' => 'モデレーターがディスカッション:discussionから投稿を復元しました。',
'discussion_restore' => 'モデレーターがディスカッション:discussionを復元しました。',
'disqualify' => ':userがDisqualifyしました。 理由::text.',

This comment has been minimized.

@nanaya

nanaya Apr 26, 2018

Collaborator

This has been changed (and disqualify_legacy has been added as well).

'duplicate_options' => '選択肢の重複があります。',
'invalid_max_options' => '選択数の上限に選択肢の数以上の数値は使用不可能です。',
'minimum_one_selection' => '選択数は1が最低の数値です。',
'minimum_two_options' => '選択肢は最低2つ必要です。。',

This comment has been minimized.

@nanaya

nanaya Apr 26, 2018

Collaborator

there's an extra trailing .

'wrong_current_password' => '誤ったパスワードです。',
'wrong_email_confirmation' => 'Eメールの確認が一致しません。',
'wrong_password_confirmation' => 'パスワードの確認が一致しません。',
'too_long' => ' :limit文字です。',

This comment has been minimized.

@nanaya

nanaya Apr 26, 2018

Collaborator

is it correct? Looks like missing まで (or some other limit words - 上限, 超えた, etc) to me.

This comment has been minimized.

@Soukyuen

Soukyuen Apr 26, 2018

Contributor

for some reason when I saw it in English it said ':limit characters.'
I probably left off after deleting most of it then came back to it without giving it much thought... nice catch

*/
return [
'months' => 'ヶ月',

This comment has been minimized.

@nanaya

nanaya Apr 26, 2018

Collaborator

Is it correct ? It's used like this:

https://osu.ppy.sh/store/products/supporter-tag

This comment has been minimized.

@Soukyuen

Soukyuen Apr 26, 2018

Contributor

oh wow that's awful

Soukyuen and others added some commits Apr 26, 2018

@nanaya

nanaya approved these changes Apr 27, 2018

@nanaya nanaya merged commit b2e0212 into ppy:master Apr 27, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment