Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch beatmap search rank filter to filter on beatmap_id #3074

Conversation

@notbakaneko
Copy link
Collaborator

@notbakaneko notbakaneko commented Apr 24, 2018

Filter on beatmap_id instead, removing the extraneous database query.

@@ -236,6 +218,10 @@ private function getPlayedBeatmapIds()
->forUser($this->params->user)
->select('beatmap_id');

if ($rank !== null) {

This comment has been minimized.

@notbakaneko

notbakaneko Apr 24, 2018
Author Collaborator

may be better as !empty($rank) with a default of []? I dunno

@@ -227,7 +209,7 @@ private function getDefaultSort() : array
return [new Sort('approved_date', 'desc')];
}

private function getPlayedBeatmapIds()
private function getRankedBeatmapIds(?array $rank = null)

This comment has been minimized.

@nanaya

nanaya Apr 24, 2018
Collaborator

previous name is better because ranked beatmap can mean something else.

@nanaya
nanaya approved these changes Apr 24, 2018
@nanaya nanaya merged commit d875959 into ppy:master Apr 24, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peppy peppy added this to the April 2018 milestone Apr 25, 2018
@notbakaneko notbakaneko deleted the notbakaneko:feature/beatmapset-search-rank-filter-on-beatmap_ids branch Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants