Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch beatmap search rank filter to filter on beatmap_id #3074

Conversation

notbakaneko
Copy link
Collaborator

Filter on beatmap_id instead, removing the extraneous database query.

@@ -236,6 +218,10 @@ private function getPlayedBeatmapIds()
->forUser($this->params->user)
->select('beatmap_id');

if ($rank !== null) {

This comment was marked as off-topic.

@@ -227,7 +209,7 @@ private function getDefaultSort() : array
return [new Sort('approved_date', 'desc')];
}

private function getPlayedBeatmapIds()
private function getRankedBeatmapIds(?array $rank = null)

This comment was marked as off-topic.

@nanaya nanaya merged commit d875959 into ppy:master Apr 24, 2018
@peppy peppy added this to the April 2018 milestone Apr 25, 2018
@notbakaneko notbakaneko deleted the feature/beatmapset-search-rank-filter-on-beatmap_ids branch April 27, 2018 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants