Make user modding history public #3080
Merged
Conversation
links need text :D
Are we removing global overview ?_? (as in not specific to certain user) |
This reverts commit 1e30f29.
I guess not |
996fec6
to
776690c
<span class="beatmap-discussion-post__user-text u-ellipsis-overflow">{!! link_to_user($post->user) !!}</span> | ||
</div> | ||
</div> | ||
@component('beatmapset_activities._user', ['user' => $post->user]) |
nanaya
Apr 26, 2018
Collaborator
how about plain @include
ಠ_ಠ (also other places with no slot content)
how about plain @include
ಠ_ಠ (also other places with no slot content)
notbakaneko
Apr 26, 2018
•
Author
Collaborator
@include
with no $slot
explodes
@include
with no $slot
explodes
nanaya
Apr 26, 2018
Collaborator
$slot ?? ''
?
$slot ?? ''
?
notbakaneko
Apr 26, 2018
Author
Collaborator
just so @include
can be used? yeah, no
just so @include
can be used? yeah, no
nanaya
Apr 26, 2018
Collaborator
but they're same thing with just with some $slot
magic.
but they're same thing with just with some $slot
magic.
resources/lang/es/layout.php
Outdated
@@ -118,7 +118,7 @@ | |||
'settings' => 'Opciones', | |||
'logout' => 'Cerrar sesión', | |||
'help' => 'Ayuda', | |||
'beatmapset_activities' => 'actividades del usuario en el beatmap', | |||
'user-modding-history' => 'actividades del usuario en el beatmap', // needs update |
nanaya
Apr 26, 2018
Collaborator
the key doesn't seem right
the key doesn't seem right
@props.user.username | ||
|
||
a | ||
className: "#{bn}__user-modding-history-link" |
notbakaneko
Apr 26, 2018
Author
Collaborator
apparently
apparently
style: | ||
color: userColor | ||
|
||
a |
nanaya
Apr 26, 2018
Collaborator
looking again, not sure if worth it linking the whole thing or just link username and avatar separately instead.
looking again, not sure if worth it linking the whole thing or just link username and avatar separately instead.
notbakaneko
Apr 26, 2018
Author
Collaborator
┐(ツ)┌
┐(ツ)┌
routes/web.php
Outdated
Route::get('users/{user}/posts', 'UsersController@posts')->name('users.posts'); | ||
|
||
Route::group(['as' => 'users.modding.', 'namespace' => 'Users'], function () { |
nanaya
Apr 26, 2018
Collaborator
should use prefix
more ('prefix' => 'users/{user}/modding'
).
should use prefix
more ('prefix' => 'users/{user}/modding'
).
</a> | ||
</span> | ||
<div class="beatmapset-activities__user-upvote-list"> | ||
<h3>{{ trans('users.beatmapset_activities.votes_received.title_most') }}</h3> |
<span class="beatmap-discussion-post__user-text u-ellipsis-overflow">{{$userVotes->sum('score') > 0 ? '+' : ''}}{{$userVotes->sum('score')}} ({{count($userVotes)}} votes)</span> | ||
</a> | ||
<div class="beatmapset-activities__user-upvote-list"> | ||
<h3>{{ trans('users.beatmapset_activities.votes_made.title_most') }}</h3> |
nanaya
Apr 26, 2018
Collaborator
same about outside list container.
same about outside list container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #2675
moves the user modding history stuff toAdds user-specific modding history stuff to/users/{user}/modding
/users/{user}/modding