Make user modding history public #3080

notbakaneko · 2018-04-25T06:11:36Z

fixes #2675

is terrible 🔥
~~moves the user modding history stuff to /users/{user}/modding~~ Adds user-specific modding history stuff to /users/{user}/modding
adds a little icon next to the username in discussion posts that goes to the user's modding history
the views, styles, etc. need to be fixed separately

links need text :D

nanaya · 2018-04-25T06:43:40Z

Are we removing global overview ?_? (as in not specific to certain user)

This reverts commit 1e30f29.

notbakaneko · 2018-04-25T06:58:57Z

I guess not

except the per-user one

resources/views/beatmap_discussion_posts/_item.blade.php

-                                <span class="beatmap-discussion-post__user-text u-ellipsis-overflow">{!! link_to_user($post->user) !!}</span>
-                            </div>
-                        </div>
+                        @component('beatmapset_activities._user', ['user' => $post->user])


resources/lang/es/layout.php

@@ -118,7 +118,7 @@
            'settings' => 'Opciones',
            'logout' => 'Cerrar sesión',
            'help' => 'Ayuda',
-            'beatmapset_activities' => 'actividades del usuario en el beatmap',
+            'user-modding-history' => 'actividades del usuario en el beatmap', // needs update


resources/assets/coffee/react/beatmap-discussions/post.coffee

+                @props.user.username
+
+              a
+                className: "#{bn}__user-modding-history-link"


resources/assets/coffee/react/beatmap-discussions/post.coffee

          style:
            color: userColor
+
+          a


routes/web.php

 Route::get('users/{user}/posts', 'UsersController@posts')->name('users.posts');
+
+Route::group(['as' => 'users.modding.', 'namespace' => 'Users'], function () {


resources/views/users/beatmapset_activities.blade.php

-                            </a>
-                        </span>
+            <div class="beatmapset-activities__user-upvote-list">
+                <h3>{{ trans('users.beatmapset_activities.votes_received.title_most') }}</h3>


resources/views/users/beatmapset_activities.blade.php

-                            <span class="beatmap-discussion-post__user-text u-ellipsis-overflow">{{$userVotes->sum('score') > 0 ? '+' : ''}}{{$userVotes->sum('score')}} ({{count($userVotes)}} votes)</span>
-                        </a>
+            <div class="beatmapset-activities__user-upvote-list">
+                <h3>{{ trans('users.beatmapset_activities.votes_made.title_most') }}</h3>


notbakaneko added 30 commits April 25, 2018 13:58

make beatmapset-activities page public

773bdd1

add icon for user modding history link

d63fdc2

link in link fun

f4af58d

change display url to modding-history

974041f

new controllers for user modding history

9d14181

move beatmapsetActivities over to ModdingHistoryController

5c2360c

wire up new routes to existing controllers

86faa9a

use resolveCurrentPath

4743e0d

change page title

6dd8b89

update routes

27fb0fd

show username in title

ee23f5e

move modding discussion history under user namespace

d964e47

move modding discussion events under user namespace

0fd7514

move modding discussion posts under user namespace

b2fad13

set user in middleware

176d35a

remove user input

cf364ba

option to view deleted discussions only for mods

bf37a14

remove priv_check for modding history

78027d5

point existing user.beatmapset-activities to user.modding.index

d79e27e

simulate previous behaviour of links

e2a43bf

split user bit off

f8e794b

combine the beatmapset activities user part into a component

d38ce5f

make the element order the same as the one above it.

35d474c

links need text :D

page appears to be missing the actual beatmapset-activities block

31f0255

move the shonky hack

5fa797b

add beatmapset-activities block to all these pages too

dff8977

fix up links to votes

f9b32b0

move user modding history votes received/given

698f194

set actionPrefix

40dc9a0

remove old stuff

1e30f29

notbakaneko added 4 commits April 25, 2018 14:43

apply userQuery default

d4b45dd

set search params defaults via middleware

9200dc6

all the modding history routes have the same namespace now.

e7a4b27

StyleCI

0a29c49

Revert "remove old stuff"

e8509dc

This reverts commit 1e30f29.

notbakaneko added the WIP label Apr 25, 2018

notbakaneko added 6 commits April 25, 2018 16:27

add the previous overview modding routes back in.

3d98002

except the per-user one

remove :user

fce24a4

show :user's modding history title if $user is set

e189eef

make block->header order the same for each section

2fe1887

use User not required

77141e2

make overview public

776690c

notbakaneko force-pushed the feature/public-beatmapset-activities branch from 996fec6 to 776690c Compare April 25, 2018 08:03

notbakaneko removed the WIP label Apr 25, 2018

peppy added the resolves issue label Apr 26, 2018

nanaya requested changes Apr 26, 2018

View reviewed changes

notbakaneko added 4 commits April 26, 2018 20:58

more samey

132c7c0

rename to correct new controller method

399c697

whoops

d6cb485

null if no slot

396c572

nanaya approved these changes Apr 26, 2018

View reviewed changes

Merge branch 'master' into feature/public-beatmapset-activities

21f87f2

nanaya merged commit 2d2d98c into ppy:master Apr 26, 2018

notbakaneko deleted the feature/public-beatmapset-activities branch April 27, 2018 04:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make user modding history public #3080

Make user modding history public #3080

notbakaneko commented Apr 25, 2018 •

edited

Loading

nanaya commented Apr 25, 2018

notbakaneko commented Apr 25, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

		Route::get('users/{user}/posts', 'UsersController@posts')->name('users.posts');

		Route::group(['as' => 'users.modding.', 'namespace' => 'Users'], function () {

Make user modding history public #3080

Make user modding history public #3080

Conversation

notbakaneko commented Apr 25, 2018 • edited Loading

nanaya commented Apr 25, 2018

notbakaneko commented Apr 25, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

notbakaneko commented Apr 25, 2018 •

edited

Loading