Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button on user profile linking to change username store page #3082

Merged
merged 5 commits into from Apr 25, 2018

Conversation

@nekodex
Copy link
Collaborator

@nekodex nekodex commented Apr 25, 2018

After internal discussion we decided it made more sense to put the link on the user settings page amongst the rest of the changeable user profile fields.

fixes #2421

@nanaya
nanaya approved these changes Apr 25, 2018
@nanaya nanaya merged commit c2b2a46 into ppy:master Apr 25, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Lyawi
Copy link

@Lyawi Lyawi commented Apr 26, 2018

Sorry if it's not "allowed" to comment here after merging, but why not putting the button nearly the name instead of having a button looking a bit out of place?

@nekodex nekodex deleted the nekodex:change-username-link branch Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants