Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd user filter for beatmap discussions #3090
Conversation
notbakaneko
added some commits
Apr 18, 2018
| a | ||
| children: children | ||
| className: classNames | ||
| href: '#' |
This comment has been minimized.
This comment has been minimized.
peppy
added
the
resolves issue
label
Apr 26, 2018
notbakaneko
added some commits
Apr 27, 2018
peppy
assigned
MillhioreF and
nanaya
and unassigned
MillhioreF
May 7, 2018
| @@ -183,7 +183,7 @@ class BeatmapDiscussions.Discussions extends React.PureComponent | ||
| @props.mode == 'timeline' && @currentSort() == 'timeline' | ||
| sortedDisussions: -> | ||
| sortedDiscussions: (discussions) -> |
This comment has been minimized.
This comment has been minimized.
| @@ -213,6 +219,7 @@ class @BeatmapDiscussionHelper | ||
| # empty path segments are '' | ||
| mode: if _.includes(@MODES, mode) then mode else @DEFAULT_MODE | ||
| filter: if _.includes(@FILTERS, filter) then filter else @DEFAULT_FILTER | ||
| user: parseInt(url.searchParams.get('user'), 10) if url.searchParams.get('user')? |
This comment has been minimized.
This comment has been minimized.
nanaya
May 7, 2018
Collaborator
apparently there's already params variable assigned with url.searchParams (which isn't used =D )
This comment has been minimized.
This comment has been minimized.
| @@ -58,6 +59,11 @@ class BeatmapDiscussions.Main extends React.PureComponent | ||
| $.subscribe 'beatmapsetDiscussions:update.beatmapDiscussions', @update | ||
| $.subscribe 'beatmapDiscussion:jump.beatmapDiscussions', @jumpTo | ||
| $.subscribe 'beatmapDiscussionPost:markRead.beatmapDiscussions', @markPostRead | ||
| $.subscribe 'beatmapsetDiscussions:userFilterChanged.beatmapDiscussions', (_e, { selectedUserId }) => |
This comment has been minimized.
This comment has been minimized.
nanaya
May 7, 2018
Collaborator
or update update function to handle user parameter? (also cache reset is already done in componentWillUpdate)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -199,7 +207,7 @@ class BeatmapDiscussions.Main extends React.PureComponent | ||
| modes[mode] = {} | ||
| for d in @state.beatmapset.discussions | ||
| for d in @filterDiscussions(@state.beatmapset.discussions) |
This comment has been minimized.
This comment has been minimized.
| @@ -179,6 +186,7 @@ class BeatmapDiscussions.Main extends React.PureComponent | ||
| countsByBeatmap = {} | ||
| countsByPlaymode = {} | ||
| totalHype = _.filter(@state.beatmapset.discussions, message_type: 'hype', deleted_at: null).length |
This comment has been minimized.
This comment has been minimized.
| * along with osu!web. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| .beatmap-discussions-user-filter { |
This comment has been minimized.
This comment has been minimized.
nanaya
May 7, 2018
Collaborator
can't this be a modifier of beatmap-list? (maybe with class name change)
This comment has been minimized.
This comment has been minimized.
notbakaneko
May 8, 2018
Contributor
more like move to a more generic select-options component and use fragments to render
...which comes later
| return if event.button != 0 | ||
| event.preventDefault() | ||
| selectedUserId = user.id |
This comment has been minimized.
This comment has been minimized.
| a | ||
| children: children | ||
| className: classNames | ||
| href: "?user=#{key ? ''}" |
This comment has been minimized.
This comment has been minimized.
| &--stats { | ||
| flex: none; | ||
| display: flex; | ||
| flex-direction: column; |
This comment has been minimized.
This comment has been minimized.
| @@ -56,6 +56,30 @@ | ||
| } | ||
| } | ||
| &__filter-group { | ||
| min-width: 0; | ||
| flex: 1 1 auto; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
notbakaneko
added some commits
May 7, 2018
| a | ||
| children: children | ||
| className: classNames | ||
| href: BeatmapDiscussionHelper.url user: key |
This comment has been minimized.
This comment has been minimized.
nanaya
May 8, 2018
Collaborator
may want to update the function to allow updating instead of rebuilding from scratch =] (probably should've done this way earlier)
This seems to work
{...} =
if update ? false then _.assign(@urlParse(), options) else options
nanaya
merged commit e94755d
into
ppy:master
May 8, 2018
notbakaneko
deleted the
notbakaneko:feature/beatmap-discussions-user-filter
branch
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
notbakaneko commentedApr 26, 2018
fixes #2105
Entirely client-side.
"This will be a quick change"; and then it wasn't