Add user filter for beatmap discussions #3090
Conversation
needed to update the counts, etc.
| a | ||
| children: children | ||
| className: classNames | ||
| href: '#' |
notbakaneko
Apr 26, 2018
Author
Collaborator
need something else for this
need something else for this
| @@ -183,7 +183,7 @@ class BeatmapDiscussions.Discussions extends React.PureComponent | |||
| @props.mode == 'timeline' && @currentSort() == 'timeline' | |||
|
|
|||
|
|
|||
| sortedDisussions: -> | |||
| sortedDiscussions: (discussions) -> | |||
nanaya
May 7, 2018
Collaborator
parameter not used?
parameter not used?
| @@ -213,6 +219,7 @@ class @BeatmapDiscussionHelper | |||
| # empty path segments are '' | |||
| mode: if _.includes(@MODES, mode) then mode else @DEFAULT_MODE | |||
| filter: if _.includes(@FILTERS, filter) then filter else @DEFAULT_FILTER | |||
| user: parseInt(url.searchParams.get('user'), 10) if url.searchParams.get('user')? | |||
nanaya
May 7, 2018
Collaborator
apparently there's already params variable assigned with url.searchParams (which isn't used =D )
apparently there's already params variable assigned with url.searchParams (which isn't used =D )
notbakaneko
May 8, 2018
Author
Collaborator
and into the bin it goes
and into the bin it goes
| @@ -58,6 +59,11 @@ class BeatmapDiscussions.Main extends React.PureComponent | |||
| $.subscribe 'beatmapsetDiscussions:update.beatmapDiscussions', @update | |||
| $.subscribe 'beatmapDiscussion:jump.beatmapDiscussions', @jumpTo | |||
| $.subscribe 'beatmapDiscussionPost:markRead.beatmapDiscussions', @markPostRead | |||
| $.subscribe 'beatmapsetDiscussions:userFilterChanged.beatmapDiscussions', (_e, { selectedUserId }) => | |||
nanaya
May 7, 2018
Collaborator
or update update function to handle user parameter? (also cache reset is already done in componentWillUpdate)
or update update function to handle user parameter? (also cache reset is already done in componentWillUpdate)
notbakaneko
May 8, 2018
Author
Collaborator
update has state races which allows things like this to happen
update has state races which allows things like this to happen
notbakaneko
May 8, 2018
Author
Collaborator
might be browser just failing too
might be browser just failing too
| @@ -199,7 +207,7 @@ class BeatmapDiscussions.Main extends React.PureComponent | |||
| modes[mode] = {} | |||
|
|
|||
|
|
|||
| for d in @state.beatmapset.discussions | |||
| for d in @filterDiscussions(@state.beatmapset.discussions) | |||
nanaya
May 7, 2018
Collaborator
this confuses nominate button (wrong unresolved count).
this confuses nominate button (wrong unresolved count).
| @@ -179,6 +186,7 @@ class BeatmapDiscussions.Main extends React.PureComponent | |||
|
|
|||
| countsByBeatmap = {} | |||
| countsByPlaymode = {} | |||
| totalHype = _.filter(@state.beatmapset.discussions, message_type: 'hype', deleted_at: null).length | |||
nanaya
May 7, 2018
Collaborator
this can be part of the big loop...?
this can be part of the big loop...?
| * along with osu!web. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| .beatmap-discussions-user-filter { |
nanaya
May 7, 2018
Collaborator
can't this be a modifier of beatmap-list? (maybe with class name change)
can't this be a modifier of beatmap-list? (maybe with class name change)
notbakaneko
May 8, 2018
Author
Collaborator
more like move to a more generic select-options component and use fragments to render
...which comes later
more like move to a more generic select-options component and use fragments to render
...which comes later
| return if event.button != 0 | ||
| event.preventDefault() | ||
|
|
||
| selectedUserId = user.id |
nanaya
May 7, 2018
Collaborator
pass key: value directly in the $.publish call? ಠ_ಠ
pass key: value directly in the $.publish call? ಠ_ಠ
| a | ||
| children: children | ||
| className: classNames | ||
| href: "?user=#{key ? ''}" |
nanaya
May 7, 2018
Collaborator
use the helper .url instead?
use the helper .url instead?
| &--stats { | ||
| flex: none; | ||
| display: flex; | ||
| flex-direction: column; |
nanaya
May 7, 2018
Collaborator
something here seems to cause incorrect alignment
something here seems to cause incorrect alignment
| @@ -56,6 +56,30 @@ | |||
| } | |||
| } | |||
|
|
|||
| &__filter-group { | |||
| min-width: 0; | |||
| flex: 1 1 auto; | |||
nanaya
May 7, 2018
Collaborator
is the full width for beatmap dropdown intentional?
is the full width for beatmap dropdown intentional?
notbakaneko
May 8, 2018
Author
Collaborator
yes
yes
null actually has a different meaning from undefined here.
notbakaneko
force-pushed the
notbakaneko:feature/beatmap-discussions-user-filter
branch
from
794b024
to
d941216
| a | ||
| children: children | ||
| className: classNames | ||
| href: BeatmapDiscussionHelper.url user: key |
nanaya
May 8, 2018
Collaborator
may want to update the function to allow updating instead of rebuilding from scratch =] (probably should've done this way earlier)
This seems to work
{...} =
if update ? false then _.assign(@urlParse(), options) else options
may want to update the function to allow updating instead of rebuilding from scratch =] (probably should've done this way earlier)
This seems to work
{...} =
if update ? false then _.assign(@urlParse(), options) else options
fixes #2105
Entirely client-side.
"This will be a quick change"; and then it wasn't