Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix modding history not applying user filter #3146
Conversation
notbakaneko
added some commits
May 8, 2018
This comment has been minimized.
This comment has been minimized.
|
wtf is this "checks" tab ヽ( ﾟ ヮﾟ)ﾉ |
peppy
added
the
resolves issue
label
May 8, 2018
| @@ -105,7 +105,7 @@ public static function search($rawParams = []) | ||
| $query->withoutDeleted(); | ||
| } | ||
| if (!($params['is_moderator'] ?? false)) { | ||
| if (!($rawParams['is_moderator'] ?? false)) { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
peppy
May 8, 2018
Member
can we stick to using sentences to comment on code rather than faces? it's very hard to follow along.
nanaya
merged commit a4848ae
into
ppy:master
May 8, 2018
notbakaneko
deleted the
notbakaneko:fix/modding-history-everyone-is-the-same
branch
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
notbakaneko commentedMay 8, 2018
•
edited
fixes #3145
also fixes
is_moderatorcheck always being false even when is a moderator.request()->all()/request()->toArray()also does not have the same values asrequest()