Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modding history not applying user filter #3146

Merged

Conversation

notbakaneko
Copy link
Collaborator

@notbakaneko notbakaneko commented May 8, 2018

fixes #3145

also fixes is_moderator check always being false even when is a moderator.

request()->all()/request()->toArray() also does not have the same values as request()

array accessor for Request always passes isset and cbf'd fixing the
::search functions to handle them properly.
@nanaya
Copy link
Collaborator

nanaya commented May 8, 2018

wtf is this "checks" tab ヽ( ゚ ヮ゚)ノ

@@ -105,7 +105,7 @@ public static function search($rawParams = [])
$query->withoutDeleted();
}

if (!($params['is_moderator'] ?? false)) {
if (!($rawParams['is_moderator'] ?? false)) {

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@nanaya nanaya merged commit a4848ae into ppy:master May 8, 2018
@notbakaneko notbakaneko deleted the fix/modding-history-everyone-is-the-same branch May 8, 2018 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Modding History is broken and showing ..collective history?
3 participants