New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modding history not applying user filter #3146

Merged
merged 3 commits into from May 8, 2018

Conversation

3 participants
@notbakaneko
Contributor

notbakaneko commented May 8, 2018

fixes #3145

also fixes is_moderator check always being false even when is a moderator.

request()->all()/request()->toArray() also does not have the same values as request()

notbakaneko added some commits May 8, 2018

just merge user_id with query into array.
array accessor for Request always passes isset and cbf'd fixing the
::search functions to handle them properly.
@nanaya

This comment has been minimized.

Collaborator

nanaya commented May 8, 2018

wtf is this "checks" tab ヽ( ゚ ヮ゚)ノ

@peppy peppy added the resolves issue label May 8, 2018

@@ -105,7 +105,7 @@ public static function search($rawParams = [])
$query->withoutDeleted();
}
if (!($params['is_moderator'] ?? false)) {
if (!($rawParams['is_moderator'] ?? false)) {

This comment has been minimized.

@nanaya

nanaya May 8, 2018

Collaborator

( ¬‿¬)

This comment has been minimized.

@notbakaneko

notbakaneko May 8, 2018

Contributor

good thing defaults to false ( ¬‿¬)

This comment has been minimized.

@peppy

peppy May 8, 2018

Member

can we stick to using sentences to comment on code rather than faces? it's very hard to follow along.

@nanaya

nanaya approved these changes May 8, 2018

@nanaya nanaya merged commit a4848ae into ppy:master May 8, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:fix/modding-history-everyone-is-the-same branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment