Fix modding history not applying user filter #3146
Merged
Conversation
array accessor for Request always passes isset and cbf'd fixing the ::search functions to handle them properly.
|
wtf is this "checks" tab ヽ( ﾟ ヮﾟ)ﾉ |
| @@ -105,7 +105,7 @@ public static function search($rawParams = []) | |||
| $query->withoutDeleted(); | |||
| } | |||
|
|
|||
| if (!($params['is_moderator'] ?? false)) { | |||
| if (!($rawParams['is_moderator'] ?? false)) { | |||
nanaya
May 8, 2018
Collaborator
( ¬‿¬)
( ¬‿¬)
notbakaneko
May 8, 2018
Author
Collaborator
good thing defaults to false ( ¬‿¬)
good thing defaults to false ( ¬‿¬)
peppy
May 8, 2018
Member
can we stick to using sentences to comment on code rather than faces? it's very hard to follow along.
can we stick to using sentences to comment on code rather than faces? it's very hard to follow along.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #3145
also fixes
is_moderatorcheck always being false even when is a moderator.request()->all()/request()->toArray()also does not have the same values asrequest()