New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spoilerbox design #3151

Merged
merged 6 commits into from May 11, 2018

Conversation

4 participants
@MegaApplePi
Contributor

MegaApplePi commented May 9, 2018

fixes #2460

@peppy peppy added the resolves issue label May 9, 2018

@@ -34,16 +34,21 @@
.@{top}.js-spoilerbox--open & {
display: block;
background: #DDD;

This comment has been minimized.

@notbakaneko

notbakaneko May 9, 2018

Contributor

lowercase

lowercase hexcode
Co-authored-by: notbakaneko <notbakaneko@users.noreply.github.com>
@@ -34,16 +34,21 @@
.@{top}.js-spoilerbox--open & {
display: block;
background: #ddd;
border-radius: 4px;

This comment has been minimized.

@nanaya

nanaya May 10, 2018

Collaborator

more like .default-border-radius().

use function to set border-radius
Co-authored-by: nanaya <nanaya@users.noreply.github.com>
@nanaya

nanaya approved these changes May 11, 2018

@nanaya nanaya merged commit d313640 into ppy:master May 11, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MegaApplePi MegaApplePi deleted the MegaApplePi:spoiler-box branch May 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment