Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show discussion starters in user filter #3152

Conversation

notbakaneko
Copy link
Collaborator

fixes #3148

@@ -121,6 +121,11 @@ class BeatmapDiscussions.Header extends React.PureComponent
beatmap: @props.currentBeatmap


discussionUsers: =>

This comment was marked as off-topic.

@@ -121,6 +121,11 @@ class BeatmapDiscussions.Header extends React.PureComponent
beatmap: @props.currentBeatmap


discussionUsers: =>
userIds = _.uniq(_.map(_.values(@props.discussions), 'user_id'))
_.pickBy(@props.users, (value) -> _.includes(userIds, value.id))

This comment was marked as off-topic.

@nanaya nanaya merged commit 6c86cbc into ppy:master May 9, 2018
@notbakaneko notbakaneko deleted the feature/beatmap-discussions-user-filter-only-starter branch May 10, 2018 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users that only replied got to "filter by user" list
4 participants