Only show discussion starters in user filter #3152
Merged
Conversation
| @@ -121,6 +121,11 @@ class BeatmapDiscussions.Header extends React.PureComponent | |||
| beatmap: @props.currentBeatmap | |||
|
|
|||
|
|
|||
| discussionUsers: => | |||
nekodex
May 9, 2018
Collaborator
How about discussionStarters or something to be more descriptive?
Also not sure if it's better to do this once-off when discussions are loaded as opposed to each render?
How about discussionStarters or something to be more descriptive?
Also not sure if it's better to do this once-off when discussions are loaded as opposed to each render?
| @@ -121,6 +121,11 @@ class BeatmapDiscussions.Header extends React.PureComponent | |||
| beatmap: @props.currentBeatmap | |||
|
|
|||
|
|
|||
| discussionUsers: => | |||
| userIds = _.uniq(_.map(_.values(@props.discussions), 'user_id')) | |||
| _.pickBy(@props.users, (value) -> _.includes(userIds, value.id)) | |||
nanaya
May 9, 2018
Collaborator
Here have a magic thingy chained written in javascript.
_($r.props.discussions).map('user_id').uniq().map(function(k){return $r.props.users[k]}).sortBy('username').value()
Here have a magic thingy chained written in javascript.
_($r.props.discussions).map('user_id').uniq().map(function(k){return $r.props.users[k]}).sortBy('username').value()
notbakaneko
deleted the
notbakaneko:feature/beatmap-discussions-user-filter-only-starter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #3148