Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly show discussion starters in user filter #3152
Conversation
notbakaneko
added
the
modding discussions
label
May 9, 2018
| @@ -121,6 +121,11 @@ class BeatmapDiscussions.Header extends React.PureComponent | ||
| beatmap: @props.currentBeatmap | ||
| discussionUsers: => |
This comment has been minimized.
This comment has been minimized.
nekodex
May 9, 2018
Collaborator
How about discussionStarters or something to be more descriptive?
Also not sure if it's better to do this once-off when discussions are loaded as opposed to each render?
peppy
added
the
resolves issue
label
May 9, 2018
| @@ -121,6 +121,11 @@ class BeatmapDiscussions.Header extends React.PureComponent | ||
| beatmap: @props.currentBeatmap | ||
| discussionUsers: => | ||
| userIds = _.uniq(_.map(_.values(@props.discussions), 'user_id')) | ||
| _.pickBy(@props.users, (value) -> _.includes(userIds, value.id)) |
This comment has been minimized.
This comment has been minimized.
nanaya
May 9, 2018
Collaborator
Here have a magic thingy chained written in javascript.
_($r.props.discussions).map('user_id').uniq().map(function(k){return $r.props.users[k]}).sortBy('username').value()
notbakaneko
and others
added some commits
May 9, 2018
nanaya
merged commit 6c86cbc
into
ppy:master
May 9, 2018
notbakaneko
deleted the
notbakaneko:feature/beatmap-discussions-user-filter-only-starter
branch
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
notbakaneko commentedMay 9, 2018
fixes #3148