Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort qualified beatmap listing according to qualified queue date #3154


Copy link

fixes #3072

Maps that are not in the queue will be ordered below those that are, regardless of sort direction.

index mapping should be updated first so that the query doesn't die while the field doesn't exist
curl -XPUT -H "Content-Type: application/json" http://ES_HOST/beatmaps/_mapping/beatmaps -d '{ "properties": { "queued_at": { "type": "date" } } }'

@@ -68,15 +68,15 @@ public function __construct(Request $request, ?User $user = null)

$sort = explode('_', $request['sort']);
$this->sort = static::normalizeSort(
$this->sort = $this->normalizeSort(

This comment was marked as off-topic.

This comment was marked as off-topic.

@nanaya nanaya merged commit 8b8e4ea into ppy:master May 18, 2018
@notbakaneko notbakaneko deleted the feature/beatmap-search-qualified-expected-rank-sort branch June 29, 2018 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Qualified listing needs a sorting option reflecting the qualified queue
3 participants