Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retina-ify beatmapset-panel #3166

Merged
merged 4 commits into from May 11, 2018

Conversation

3 participants
@nekodex
Copy link
Collaborator

nekodex commented May 10, 2018

This had been bothering me, so I fixed it.

(also includes a bit of cleanup, removing an unneeded container class or two)

nekodex added some commits May 10, 2018

@@ -16,7 +16,7 @@
# along with osu!web. If not, see <http://www.gnu.org/licenses/>.
###

{div,a,i,span} = ReactDOMFactories
{div,a,i,img,span} = ReactDOMFactories

This comment has been minimized.

@notbakaneko

notbakaneko May 11, 2018

Contributor

looks unused

@@ -43,6 +43,11 @@ class @BeatmapsetPanel extends React.PureComponent
$(document).off ".#{@eventId}"


hideImage: (e) ->
# hides img elements that have errored (hides native browser broken-image icons)
e.currentTarget.style.display = 'none';

This comment has been minimized.

@notbakaneko

notbakaneko May 11, 2018

Contributor

is that a semicolon

@peppy peppy added this to the May 2018 milestone May 11, 2018

@notbakaneko notbakaneko merged commit 1d824a4 into ppy:master May 11, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.