Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter blank discussions and change to case-insensitive username sort #3170



Copy link

@notbakaneko notbakaneko commented May 11, 2018

fixes #3167 and makes username sorting case-insensitive

@@ -276,16 +276,17 @@ class BeatmapDiscussions.Main extends React.PureComponent

discussions: =>
@cache.discussions ?= _.keyBy @state.beatmapset.discussions, 'id'
@cache.discussions ?= _ @state.beatmapset.discussions
.filter (d) -> !_.isEmpty(d)

This comment has been minimized.


nanaya May 11, 2018

Or reject ... -> _.isEmpty .... And looks like currentDiscussions can use this function as well (and remove similar check in it).

nanaya approved these changes May 11, 2018
@nanaya nanaya merged commit 9fa1a39 into ppy:master May 11, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
continuous-integration/travis-ci/pr The Travis CI build passed
@notbakaneko notbakaneko deleted the notbakaneko:feature/beatmap-discussion-user-filter-fixes branch May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants