Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter blank discussions and change to case-insensitive username sort #3170

Merged

Conversation

notbakaneko
Copy link
Collaborator

fixes #3167 and makes username sorting case-insensitive

@@ -276,16 +276,17 @@ class BeatmapDiscussions.Main extends React.PureComponent


discussions: =>
@cache.discussions ?= _.keyBy @state.beatmapset.discussions, 'id'
@cache.discussions ?= _ @state.beatmapset.discussions
.filter (d) -> !_.isEmpty(d)

This comment was marked as off-topic.

@nanaya nanaya merged commit 9fa1a39 into ppy:master May 11, 2018
@notbakaneko notbakaneko deleted the feature/beatmap-discussion-user-filter-fixes branch May 11, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mysterious [deleted user] in user filter
2 participants