Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discussionLinkify #3177

Merged
merged 1 commit into from May 14, 2018

Conversation

2 participants
@nanaya
Copy link
Collaborator

nanaya commented May 11, 2018

Repeating text.replace call for each urls don't work because it may incorrectly replace previously linkified urls.

Fixes #3176.

Fix discussionLinkify
Repeating `text.replace` call for each urls don't work because it may incorrectly replace previously linkified urls.
@peppy

peppy approved these changes May 14, 2018

@peppy peppy merged commit 7b731cf into ppy:master May 14, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nanaya nanaya deleted the nanaya:discussion_linkify_fix branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.