New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-check topic create auth #3203

Merged
merged 6 commits into from May 25, 2018

Conversation

3 participants
@nanaya
Collaborator

nanaya commented May 15, 2018

Fixes #3180.

@nekodex

This comment has been minimized.

Collaborator

nekodex commented May 17, 2018

I'd probably just make the not-logged-in behaviour be the same as the has-no-permission behaviour (i.e. disabled/greyed out saying 'please login' or whatever)?

Feels weird, especially in the case where you go from clicking new topic -> logging in -> button greyed out because you don't have permission to post

@peppy peppy merged commit e6464ae into ppy:master May 25, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nanaya nanaya deleted the nanaya:topic_create_login_check branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment