Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete scores on qualification #3207

Merged
merged 5 commits into from Jun 1, 2018
Merged

Delete scores on qualification #3207

merged 5 commits into from Jun 1, 2018

Conversation

@nanaya
Copy link
Collaborator

@nanaya nanaya commented May 15, 2018

Fixes #2787.

foreach (Beatmap::MODES as $mode => $_modeInt) {
static::scoreClass($mode)::whereIn('beatmap_id', $beatmapIds)
->orderBy('score_id')
->where('score_id', '<', $this->maxScoreIds[$mode])

This comment has been minimized.

@nekodex

nekodex May 17, 2018
Collaborator

Shouldn't this be <=?

Include the recorded max score_id.
@peppy peppy merged commit 7ed3659 into ppy:master Jun 1, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nanaya nanaya deleted the nanaya:score_delete branch Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants