Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show past tournaments on the tournament listing #3209

Merged
merged 3 commits into from May 18, 2018

Conversation

nekodex
Copy link
Collaborator

@nekodex nekodex commented May 16, 2018

Will probably need to add pagination later, but should be ok for the time being.

fixes #3165

nanaya
nanaya previously requested changes May 17, 2018
Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

$current = $tournaments->where('end_date', '>', Carbon::now());
$previous = $tournaments->where('end_date', '<=', Carbon::now());

return [

This comment was marked as off-topic.

->where('signup_open', '<', Carbon::now())
->where('signup_close', '>', Carbon::now())
->orderBy('play_mode', 'desc')
$tournaments = self::query()

This comment was marked as off-topic.

->orderBy('tournament_id', 'desc')
->get();

$current = $tournaments->where('end_date', '>', Carbon::now());
$previous = $tournaments->where('end_date', '<=', Carbon::now());

This comment was marked as off-topic.

@peppy peppy merged commit 0e3679e into ppy:master May 18, 2018
@nekodex nekodex deleted the show-old-tournaments branch June 21, 2019 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tournament listing should show all active tournaments
3 participants