fallback keys should still be translated in case they are supposed to be empty. #3210
Conversation
|
More like those empty translations should be removed. Also Crowdin refuses to translate empty strings. |
|
if only the loop on the support page didn't literally rely on the translated string being empty |
|
I think this is fine. We can remove the strings where possible going forwards, but this will blanket fix these popping up in various places. |
| @@ -29,11 +29,7 @@ function trans($key = null, $replace = [], $locale = null) | |||
| if ($translated === null) { | |||
| $fallbackLocale = config('app.fallback_locale'); | |||
|
|
|||
| if ($locale === $fallbackLocale) { | |||
nanaya
May 16, 2018
Collaborator
a bunch of stuff in this function is now useless if we're refetching on fallback locale. Or only refetch on non-fallbacks.
a bunch of stuff in this function is now useless if we're refetching on fallback locale. Or only refetch on non-fallbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #3208