Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback keys should still be translated in case they are supposed to be empty. #3210

Merged
merged 1 commit into from May 16, 2018

Conversation

notbakaneko
Copy link
Collaborator

fixes #3208

@nanaya
Copy link
Collaborator

nanaya commented May 16, 2018

More like those empty translations should be removed. Also Crowdin refuses to translate empty strings.

@notbakaneko
Copy link
Collaborator Author

if only the loop on the support page didn't literally rely on the translated string being empty

@peppy
Copy link
Sponsor Member

peppy commented May 16, 2018

I think this is fine. We can remove the strings where possible going forwards, but this will blanket fix these popping up in various places.

@peppy peppy merged commit 3d15b9d into ppy:master May 16, 2018
@@ -29,11 +29,7 @@ function trans($key = null, $replace = [], $locale = null)
if ($translated === null) {
$fallbackLocale = config('app.fallback_locale');

if ($locale === $fallbackLocale) {

This comment was marked as off-topic.

@notbakaneko notbakaneko deleted the fix/3208 branch June 13, 2018 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken strings on the osu!supporter page
3 participants