Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfallback keys should still be translated in case they are supposed to be empty. #3210
Conversation
This comment has been minimized.
This comment has been minimized.
|
More like those empty translations should be removed. Also Crowdin refuses to translate empty strings. |
This comment has been minimized.
This comment has been minimized.
|
if only the loop on the support page didn't literally rely on the translated string being empty |
This comment has been minimized.
This comment has been minimized.
|
I think this is fine. We can remove the strings where possible going forwards, but this will blanket fix these popping up in various places. |
peppy
added
the
resolves issue
label
May 16, 2018
peppy
merged commit 3d15b9d
into
ppy:master
May 16, 2018
| @@ -29,11 +29,7 @@ function trans($key = null, $replace = [], $locale = null) | ||
| if ($translated === null) { | ||
| $fallbackLocale = config('app.fallback_locale'); | ||
| if ($locale === $fallbackLocale) { |
This comment has been minimized.
This comment has been minimized.
nanaya
May 16, 2018
Collaborator
a bunch of stuff in this function is now useless if we're refetching on fallback locale. Or only refetch on non-fallbacks.
notbakaneko
deleted the
notbakaneko:fix/3208
branch
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
notbakaneko commentedMay 16, 2018
fixes #3208