Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't release stock if at 0 #3212

merged 2 commits into from May 16, 2018


3 participants
Copy link

notbakaneko commented May 16, 2018

No description provided.

// stock may have been directly updated to 0.
// TODO: should count reservations and available stock separately or something.
if ($this->stock <= 0) {
return false;

This comment has been minimized.


nanaya May 16, 2018


wtf does the return value do ಠ_ಠ (also in the one above)

This comment has been minimized.


notbakaneko May 16, 2018

Author Contributor

SUCCE-..wait the last one doesn't return 😕

This comment has been minimized.


nanaya May 16, 2018


looks like the original function returned the save return and then got nuked when changed to use increment.


nanaya approved these changes May 16, 2018

@nanaya nanaya merged commit 376eb26 into ppy:master May 16, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
continuous-integration/travis-ci/pr The Travis CI build passed

@peppy peppy added store bug labels May 16, 2018

@peppy peppy added this to the May 2018 milestone May 16, 2018

@peppy peppy changed the title Don't release stock if at 0. Don't release stock if at 0 May 16, 2018

@notbakaneko notbakaneko deleted the notbakaneko:feature/store/skip-stock-release-if-none branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.