Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't release stock if at 0 #3212

Merged

Conversation

@notbakaneko
Copy link
Collaborator

@notbakaneko notbakaneko commented May 16, 2018

No description provided.

// stock may have been directly updated to 0.
// TODO: should count reservations and available stock separately or something.
if ($this->stock <= 0) {
return false;

This comment has been minimized.

Loading

This comment has been minimized.

Loading

This comment has been minimized.

Loading

nanaya
nanaya approved these changes May 16, 2018
@nanaya nanaya merged commit 376eb26 into ppy:master May 16, 2018
2 checks passed
Loading
@peppy peppy added this to the May 2018 milestone May 16, 2018
@peppy peppy changed the title Don't release stock if at 0. Don't release stock if at 0 May 16, 2018
@notbakaneko notbakaneko deleted the feature/store/skip-stock-release-if-none branch May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants