New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user events for supporter and username changes #3222

Merged
merged 10 commits into from May 18, 2018

Conversation

3 participants
@notbakaneko
Contributor

notbakaneko commented May 17, 2018

fixes #3173

{
return [
'id' => $user->getKey(),
'username' => $user->username,

This comment has been minimized.

@nanaya

nanaya May 18, 2018

Collaborator

escape?

$user = static::userParams($options['user']);
$history = $options['history'];
$params = [
'text' => "<b><a href='{$user['url']}'>{$history->username_last}</a></b> has changed their username to {$history->username}!",

This comment has been minimized.

@nanaya

nanaya May 18, 2018

Collaborator

Stuff from $history still needs escaping.

$params = [
'text' => "<b><a href='{$user['url']}'>{$oldUsername}</a></b> has changed their username to {$newUsername}!",
'user_id' => $user['id'],
'date' => $history->timestamp,

This comment has been minimized.

@nanaya

nanaya May 18, 2018

Collaborator

There's no $history.

This comment has been minimized.

@notbakaneko

notbakaneko May 18, 2018

Contributor

oh whoops 💃

@nanaya

nanaya approved these changes May 18, 2018

@nanaya nanaya merged commit 86bfb28 into ppy:master May 18, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/store/supporter-add-event branch Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment