Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order checkout validation does not support null carts #3227

Merged
merged 2 commits into from May 18, 2018

Conversation

@notbakaneko
Copy link
Collaborator

@notbakaneko notbakaneko commented May 18, 2018

since #3213 explicitly makes the cart null when not found.

since #3213 checks the cart now

@notbakaneko notbakaneko force-pushed the notbakaneko:fix/store/no-cart-without-login branch from 9f45bea to e17ccec May 18, 2018
@notbakaneko notbakaneko changed the title Cart is now null when not logged in Order checkout validation does not support null carts May 18, 2018
@nanaya
nanaya approved these changes May 18, 2018
@nanaya nanaya merged commit a2be6ed into ppy:master May 18, 2018
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@notbakaneko notbakaneko deleted the notbakaneko:fix/store/no-cart-without-login branch May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants